Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summarization.keywords for py3k. Fixes #459 #463

Merged
merged 2 commits into from
Sep 30, 2015

Conversation

wcbeard
Copy link
Contributor

@wcbeard wcbeard commented Sep 23, 2015

With basic test

def test_keywords_runs(self):
pre_path = os.path.join(os.path.dirname(__file__), 'test_data')

with utils.smart_open(os.path.join(pre_path, "mihalcea_tarau.txt"), mode="r") as f:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"r" mode is default, no need to mention it explicitly

tmylk added a commit that referenced this pull request Sep 30, 2015
Fix summarization.keywords for py3k. Fixes #459
@tmylk tmylk merged commit 1906e96 into piskvorky:develop Sep 30, 2015
@tmylk
Copy link
Contributor

tmylk commented Sep 30, 2015

Thanks. Looks good. FYI More complicated asserts are in #441

@tmylk tmylk mentioned this pull request Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants