Fix for ZeroDivisionError: float division by zero in pagerank_weighted.py #851 #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns the input, if only one sentence is present in document.
tmylk
suggested changes
Sep 27, 2016
tmylk
suggested changes
Sep 27, 2016
|
Please also add a test and a line in CHANGELOG |
tmylk
approved these changes
Sep 28, 2016
Added test for single sentence input
Added test for single sentence input #851
|
Please run tests locally before committing to the main repo |
|
For some reason, this build terminated for Python 2.6, ran successfully for all other version. |
|
So, I removed the logging statement and it passed. I don't understand how. |
tmylk
suggested changes
Sep 29, 2016
| # Keeps the first sentence only. | ||
| text = text.split('\n')[0] | ||
|
|
||
| self.assertTrue(summarize(text) is not None) |
There was a problem hiding this comment.
Please assert that the return is equal to text.
|
@metalaman Thanks a lot for the PR! |
harshuljain13
pushed a commit
to harshuljain13/gensim
that referenced
this pull request
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns the original text as soon as it finds only one sentence present in the document.