Fix #851, Error is raised instead of returning text [WiP] #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return statement removed and error raised.
Removed test for single sentence input.
metalaman
changed the title
|
Please add a test that exception is raised |
|
Thanks for the improvement! |
harshuljain13
pushed a commit
to harshuljain13/gensim
that referenced
this pull request
Sep 30, 2016
…iskvorky#902) * Update summarizer.py Return statement removed and error raised. * Update test_summarization.py Removed test for single sentence input. * Update CHANGELOG.md * Update summarizer.py * Update test_wikicorpus.py * Update test_summarization.py
piskvorky
reviewed
Oct 29, 2016
| @@ -97,7 +97,7 @@ def test_text_summarization_returns_input_on_single_input_sentence(self): | |||
| # Keeps the first sentence only. | |||
| text = text.split('\n')[0] | |||
|
|
|||
| self.assertEqual(summarize(text),text) | |||
| self.assertRaises(ValueError,summarize,text) | |||
| @@ -87,7 +87,7 @@ def test_text_summarization_raises_exception_on_short_input_text(self): | |||
| text = "\n".join(text.split('\n')[:8]) | |||
|
|
|||
| self.assertTrue(summarize(text) is not None) | |||
|
|
|||
There was a problem hiding this comment.
No trailing whitespace please.
| @@ -31,7 +31,7 @@ def setUp(self): | |||
|
|
|||
|
|
|||
| def test_get_texts_returns_generator_of_lists(self): | |||
|
|
|||
| logger.debug("Current Python Version is "+str(sys.version_info)) | |||
There was a problem hiding this comment.
PEP8: space around binary operators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.