Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Deployment or Dependency on a VNet in a Separate Resource Group #64

Merged
merged 5 commits into from
Aug 8, 2019
Merged

Enable Deployment or Dependency on a VNet in a Separate Resource Group #64

merged 5 commits into from
Aug 8, 2019

Conversation

jseely
Copy link
Contributor

@jseely jseely commented May 30, 2019

This enables networking resources to be deployed into a separate resource group. Ideally this will end up being networking resources pre-configured in an RG, provisioned by the IT department, with read only access for the Service Principal being used to deploy PAS/PKS/Control Plane.

Network Resources can optionally be deployed into a separate RG by:

  • Setting pcf_vnet_rg, in tfvars, to the name of the RG where the network resources are to be deployed

The VNet here can optionally be pre-existing by:

  • Setting create_vnet = false in tfvars
  • Setting pcf_vnet = "<name_of_existing_vnet>" in tfvars

Features:

  • Deploy network resources (VNet, subnets, NSGs) into a separate resource group
  • Take a dependency on an existing VNet

@jseely
Copy link
Contributor Author

jseely commented Jun 3, 2019

@genevieve who would be the right people to talk to about getting this merged?

@genevieve
Copy link
Contributor

@jseely I believe @nmahoney-pivotal @Polar-Beard have the power 🙌

nwmahoney
nwmahoney suggested changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@nwmahoney nwmahoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jseely. We've got a couple questions for you :)

modules/infra/main.tf Show resolved Hide resolved
modules/infra/main.tf Show resolved Hide resolved
@nwmahoney nwmahoney merged commit 2ead765 into pivotal-cf:master Aug 8, 2019
@nhsieh
Copy link
Contributor

nhsieh commented Aug 15, 2019

@jseely We are going to revert this merge. terraform destroy is failing and we are not sure why. We will leave the fix to your expertise. Thanks!

ciphercules pushed a commit that referenced this pull request Aug 15, 2019
@nhsieh @notrepo05
Reverts PR #64 using separate resource group
e136140 
This reverts commit 8e7aeae.
This reverts commit 844d8f0.
This reverts commit e0de55a.
This reverts commit a4b9b32.
@nhsieh
Copy link
Contributor

nhsieh commented Aug 15, 2019

@jseely Please make another PR when ready. This one is stuck in a merged state.

@jseely
Copy link
Contributor Author

jseely commented Aug 15, 2019

ok will do, sorry for the delay in getting a fix

jseely added a commit to jseely/terraforming-azure that referenced this pull request Aug 16, 2019
@jseely
Revert "Reverts PR pivotal-cf#64 using separate resource group"
570bd24 
This reverts commit e136140.
@jseely jseely mentioned this pull request Aug 16, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmahoney nwmahoney nwmahoney approved these changes

Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jseely @genevieve @nhsieh @nwmahoney @cf-gitbot