Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Buttons Group (7.2+) #64

Closed
2 tasks done
georgeolaru opened this issue Jan 9, 2020 · 4 comments
Closed
2 tasks done

Add Support for Buttons Group (7.2+) #64

georgeolaru opened this issue Jan 9, 2020 · 4 comments
Assignees
@madalingorbanescu
Labels
enhancement New feature or request
Milestone
1.0.5

Comments

@georgeolaru
Copy link
Member

georgeolaru commented Jan 9, 2020 •
edited by madalingorbanescu
Loading

In versiunea Gutenberg 7.2 au extins block-ul default de button, oferind optiunea de a adauga mai multe butoane inline:
64386066-145a9880-d030-11e9-8f35-f0dcb1e42fb1

Am testat cu Rosa2 si am observat urmatoarele:

  • in backend butoanele apar lipite si butonul de adaugare (+) nu e centrat pe verticala
    image

  • in frontend butoanele nu apar inline, ci unele sub altele
    image
@georgeolaru georgeolaru added the enhancement New feature or request label Jan 9, 2020
@georgeolaru georgeolaru added this to the 1.0.5 milestone Jan 9, 2020
madalingorbanescu pushed a commit that referenced this issue Jan 9, 2020
New class for layout and support for buttons group see #64
902e408
madalingorbanescu added a commit that referenced this issue Jan 13, 2020
@madalingorbanescu
New class for layout and support for buttons group see #64 (#65)
e664344 
* New class for layout and support for buttons group see #64

* Negative margins on buttons parent
@madalingorbanescu
Copy link
Contributor

madalingorbanescu commented Jan 13, 2020 •
edited
Loading

Closed in #65

@georgeolaru
Copy link
Member Author

@madalingorbanescu As vrea sa fac un double check pentru doua lucruri si sa-mi spui daca sunt valide:

  1. Pe o instalare locala, cand am aplicat filtrul "None" sau "Light", textul de pe butoane ramane alb.
  2. Butoanele nu sunt aliniate pe centru, nici in editor nici in frontend.

Video: https://share.getcloudapp.com/7Kuyj2RA

image

@madalingorbanescu
Copy link
Contributor

madalingorbanescu commented Jan 14, 2020 •
edited
Loading

@georgeolaru Da, amandoua probleme sunt valide. Am redeschis issue-ul si voi cauta o solutie.

madalingorbanescu pushed a commit that referenced this issue Jan 14, 2020
Adjust button style for light and dark content see #64
280a820
@madalingorbanescu
Copy link
Contributor

Cam asa se prezinta acum: https://share.getcloudapp.com/Jru7yqwo

@razwan razwan closed this as completed Jan 15, 2020
razwan pushed a commit that referenced this issue Jan 28, 2020
@razwan
Adjust button style for light and dark content see #64
b798e5d
razwan pushed a commit that referenced this issue Jan 30, 2020
@razwan
Adjust button style for light and dark content see #64
04c5108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madalingorbanescu madalingorbanescu

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.5
Development

No branches or pull requests
3 participants
@georgeolaru @razwan @madalingorbanescu