Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade go-git #1935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

vihangm
Copy link
Member

@vihangm vihangm commented May 30, 2024

Summary: This is to address a CVE.

Relevant Issues: CVE-2023-49569

Type of change: /kind cve

Test Plan: Ran the versions gen script, ensured it still works.

Signed-off-by: Vihang Mehta <vihang@px.dev>
@vihangm vihangm requested review from a team as code owners May 30, 2024 01:49
+ cgo = True,
importpath = "github.com/cloudflare/circl/math/fp448",
visibility = ["//visibility:public"],
deps = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this patch? Does this work around the fact that our go toolchain is old?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, newer bazel tooling will make the patching easier, but the main issue is that circl has a odd cgo setup that gazelle doesn't handle automatic build file generation for. So we have to patch what gazelle generates.

See bazel-contrib/bazel-gazelle#1543 and google/go-github#2932 for other folks who ran into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants