Skip to content

Commit

Permalink
Update playwright snapshots
Browse files Browse the repository at this point in the history
  • Loading branch information
twschiller committed Nov 14, 2024
1 parent 7deff60 commit c2fb6c9
Show file tree
Hide file tree
Showing 14 changed files with 73 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@ export class PageEditorPage extends BasePageObject {
// cleaned up after the test. Future work is adding affordance to clean up saved
// mods, with an option to avoid cleanup for certain mods.
await this.modListingPanel.activeModListItem.saveButton.click();

// Since 2.2.1, Page Editor shows commit message dialog when saving an existing mod
const saveDialog = this.getByRole("dialog");
await expect(saveDialog).toBeVisible();
await saveDialog
.getByRole("textbox", { name: "Message" })
.fill("Commit message");
await saveDialog.getByRole("button", { name: "Save" }).click();
await expect(saveDialog).toBeHidden();

await expect(
this.page.getByRole("status").filter({ hasText: "Saved mod" }),
).toBeVisible();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ options:
metadata:
id: >-
@extension-e2e-test-unaffiliated/new-mod-00000000-0000-0000-0000-000000000000
version: 1.0.0
version: 1.0.1
name: New Mod
description: Created by playwright test for adding starter bricks to a mod
variables:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ Index: add-context-menu-starter-brick-to-mod
id: >-
@extension-e2e-test-unaffiliated/new-mod-00000000-0000-0000-0000-000000000000
name: New Mod
version: 1.0.0
- version: 1.0.1
+ version: 1.0.2
options:
schema:
properties: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ Index: add-quick-bar-starter-brick-to-mod
id: >-
@extension-e2e-test-unaffiliated/new-mod-00000000-0000-0000-0000-000000000000
name: New Mod
version: 1.0.0
- version: 1.0.2
+ version: 1.0.3
options:
schema:
properties: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ Index: add-sidebar-panel-starter-brick-to-mod
id: >-
@extension-e2e-test-unaffiliated/new-mod-00000000-0000-0000-0000-000000000000
name: New Mod
version: 1.0.0
- version: 1.0.3
+ version: 1.0.4
options:
schema:
properties: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Index: add-trigger-starter-brick-to-mod
===================================================================
--- add-trigger-starter-brick-to-mod
+++ add-trigger-starter-brick-to-mod
@@ -91,80 +91,88 @@
@@ -91,101 +91,109 @@
- '@pixiebrix/document-context'
- element: '@pixiebrix/html/element'
reportMode: once
Expand Down Expand Up @@ -91,3 +91,25 @@ Index: add-trigger-starter-brick-to-mod
id: extensionPoint4
label: Sidebar Panel
permissions:
origins: []
permissions: []
services: {}
kind: recipe
metadata:
description: Created by playwright test for adding starter bricks to a mod
id: >-
@extension-e2e-test-unaffiliated/new-mod-00000000-0000-0000-0000-000000000000
name: New Mod
- version: 1.0.4
+ version: 1.0.5
options:
schema:
properties: {}
type: object
uiSchema:
ui:order:
- '*'
variables:
schema:
properties: {}
type: object
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ Index: brick-added
id: >-
@extension-e2e-test-unaffiliated/brick-actions-00000000-0000-0000-0000-000000000000
name: Mod Actions Test
version: 1.0.0
- version: 1.0.0
+ version: 1.0.1
options:
schema:
properties: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ Index: brick-copied-to-another-mod
id: >-
@extension-e2e-test-unaffiliated/simple-sidebar-panel-00000000-0000-0000-0000-000000000000
name: Simple Sidebar Panel
version: 1.0.0
- version: 1.0.0
+ version: 1.0.1
options:
schema:
properties: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Index: brick-copy-pasted
===================================================================
--- brick-copy-pasted
+++ brick-copy-pasted
@@ -6,80 +6,88 @@
@@ -6,82 +6,90 @@
containerSelector: span:has(> span:contains('Review in codespace'))
isAvailable:
allFrames: true
Expand Down Expand Up @@ -81,7 +81,8 @@ Index: brick-copy-pasted
id: >-
@extension-e2e-test-unaffiliated/brick-actions-00000000-0000-0000-0000-000000000000
name: Mod Actions Test
version: 1.0.0
- version: 1.0.2
+ version: 1.0.3
options:
schema:
properties: {}
Expand All @@ -91,3 +92,5 @@ Index: brick-copy-pasted
- '*'
variables:
schema:
properties: {}
type: object
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Index: brick-removed
===================================================================
--- brick-removed
+++ brick-removed
@@ -6,86 +6,80 @@
@@ -6,88 +6,82 @@
containerSelector: span:has(> span:contains('Review in codespace'))
isAvailable:
allFrames: true
Expand Down Expand Up @@ -79,7 +79,8 @@ Index: brick-removed
id: >-
@extension-e2e-test-unaffiliated/brick-actions-00000000-0000-0000-0000-000000000000
name: Mod Actions Test
version: 1.0.0
- version: 1.0.1
+ version: 1.0.2
options:
schema:
properties: {}
Expand All @@ -89,3 +90,5 @@ Index: brick-removed
- '*'
variables:
schema:
properties: {}
type: object
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ Index: bricks-moved
id: >-
@extension-e2e-test-unaffiliated/brick-actions-00000000-0000-0000-0000-000000000000
name: Mod Actions Test
version: 1.0.0
- version: 1.0.3
+ version: 1.0.4
options:
schema:
properties: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ Index: starter-brick-configuration-changes
id: >-
@extension-e2e-test-unaffiliated/brick-configuration-00000000-0000-0000-0000-000000000000
name: Test mod - Brick Configuration
version: 1.0.0
- version: 1.0.0
+ version: 1.0.1
options:
schema:
properties: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ Index: updated-inputs
===================================================================
--- updated-inputs
+++ updated-inputs
@@ -30,49 +30,60 @@
@@ -27,52 +27,63 @@
- children:
- children:
- config:
heading: h1
title: !nunjucks Simple Sidebar Panel
type: header
Expand Down Expand Up @@ -40,7 +43,8 @@ Index: updated-inputs
id: >-
@extension-e2e-test-unaffiliated/simple-sidebar-panel-00000000-0000-0000-0000-000000000000
name: Simple Sidebar Panel (Updated)
version: 1.0.2
- version: 1.0.2
+ version: 1.0.3
options:
schema:
- properties: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,5 +116,14 @@ test("shows error notification when updating a public mod without incrementing t
"8203 Repro Updated",
);
await pageEditorPage.modListingPanel.activeModListItem.saveButton.click();

const saveDialog = pageEditorPage.getByRole("dialog");
await expect(saveDialog).toBeVisible();
await saveDialog.getByRole("textbox", { name: "New Version" }).fill("1.0.0");
await saveDialog
.getByRole("textbox", { name: "Message" })
.fill("Commit message");
await saveDialog.getByRole("button", { name: "Save" }).click();

await expect(pageEditorPage.getIncrementVersionErrorToast()).toBeVisible();
});

0 comments on commit c2fb6c9

Please sign in to comment.