Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanly handle context invalidation (extension updates/reloads) #627

Closed
fregante opened this issue Jun 27, 2021 · 0 comments · Fixed by #2660
Closed

Cleanly handle context invalidation (extension updates/reloads) #627

fregante opened this issue Jun 27, 2021 · 0 comments · Fixed by #2660

Comments

@fregante
Copy link
Contributor

fregante commented Jun 27, 2021

This is mostly a DX issue, but it might appear if the extension reloads while the user has open tabs.


If I reload the background page, the dev tools and content scripts permanently (?) lose the connection to the background page and should probably be reloaded if possible. The error could definitely be shown more prominently (e.g. a non-dismissible red bar saying "Extension needs to reload")

Now all I get is this when trying to connect to GAPI:

Screen Shot

But everything else just silently fails:

Screen Shot 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant