Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static trial expiration banner in Sidebar and Page Editor #9196

Closed
mnholtz opened this issue Sep 23, 2024 · 0 comments · Fixed by #9271
Closed

Static trial expiration banner in Sidebar and Page Editor #9196

mnholtz opened this issue Sep 23, 2024 · 0 comments · Fixed by #9271
Assignees
@mnholtz
Labels
enhancement New feature or request

Comments

@mnholtz
Copy link
Collaborator

mnholtz commented Sep 23, 2024

Phase Spec

Acceptance Criteria

Scenario 1: Sidebar banner

  • Given a user with an expired Business trial
    When they open the PixieBrix sidebar
    Then a banner is displayed at the top of the sidebar (over all mod tabs)

Scenario 2: Page Editor banner

  • Given a user with an expired Business trial
    When they open the Page Editor
    Then an expired Business trial banner is displayed over the editor
@mnholtz mnholtz changed the title Static expiration banner in Sidebar, Page Editor Static trial expiration banner in Sidebar, Page Editor Sep 23, 2024
@mnholtz mnholtz changed the title Static trial expiration banner in Sidebar, Page Editor Static trial expiration banner in Sidebar and Page Editor Sep 23, 2024
@mnholtz mnholtz mentioned this issue Sep 23, 2024
Closed
5 tasks
@twschiller twschiller added the enhancement New feature or request label Oct 1, 2024
@mnholtz mnholtz self-assigned this Oct 10, 2024
@mnholtz mnholtz mentioned this issue Oct 10, 2024
Merged
mnholtz added a commit that referenced this issue Oct 15, 2024
@mnholtz
#9196 Paywall banner in Sidebar and Page Editor (#9271)
1cfa77b 
* refactor move teamTrials directory to src/components

* add trial status to Sidebar and Page Editor if expired

* fix hook location in SidebarBody

* add flex display to containing divs

* remove isolatedComponent style

* fix page editor vertical scrolling

* fix SidebarBody tests

* revert display: flex in document.tsx

* add comment and change overflow: hidden -> auto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnholtz mnholtz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#9196 Paywall banner in Sidebar and Page Editor pixiebrix/pixiebrix-extension
2 participants
@twschiller @mnholtz