#9196 Paywall banner in Sidebar and Page Editor #9271
Conversation
Playwright test results
Details
Flaky testsmsedge › tests/modLifecycle.spec.ts › create, run, package, and update mod Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9271 +/- ##
==========================================
+ Coverage 74.24% 75.14% +0.89%
==========================================
Files 1332 1368 +36
Lines 40817 42225 +1408
Branches 7634 7867 +233
==========================================
+ Hits 30306 31731 +1425
+ Misses 10511 10494 -17 ☔ View full report in Codecov by Sentry. |
| @@ -27,7 +27,7 @@ | |||
| <base target="_blank" /> | |||
| </head> | |||
| <body class="h-100"> | |||
| <div id="container" class="h-100 full-height"> | |||
| <div id="container" class="h-100 full-height align-items-stretch"> | |||
There was a problem hiding this comment.
This along with the change to EditorLayout.scss fixes vertical scrolling issues when banners are present in the page editor
| @@ -15,11 +15,11 @@ | |||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| */ | |||
|
|
|||
| import TrialCallToActionLink from "@/extensionConsole/pages/teamTrials/TrialCallToActionLink"; | |||
| import useGetAllTeamScopes from "@/extensionConsole/pages/teamTrials/useGetAllTeamScopes"; | |||
| import TrialCallToActionLink from "@/components/teamTrials/TrialCallToActionLink"; | |||
There was a problem hiding this comment.
NIT: I know its outside the scope of your PR, but any reason that TrialAwareButton isn't the default export for the file?
There was a problem hiding this comment.
No idea; I don't see why not though
There was a problem hiding this comment.
No idea; I don't see why not though
If you have a moment, please make it a default export. Otherwise, just go ahead and merge
| @@ -18,6 +18,7 @@ | |||
| .root { | |||
| display: flex; | |||
| height: inherit; | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
Add comment explaining why overflow is hidden vs. scrolling. E.g., cross referencing with comment https://github.com/pixiebrix/pixiebrix-extension/pull/9271/files#r1801656264
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
…ps://github.com/pixiebrix/pixiebrix-extension into feature/9196_paywall_in_sidebar_and_page_editor merge origin
What does this PR do?
teamTrials/directory tosrc/components