Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1475 Collapsable sidebar #1548

Merged
merged 10 commits into from
Oct 5, 2021
Merged

#1475 Collapsable sidebar #1548

merged 10 commits into from
Oct 5, 2021

Conversation

BALEHOK
Copy link
Contributor

@BALEHOK BALEHOK commented Sep 30, 2021

Closes #1475

image

image

@BALEHOK BALEHOK requested review from twschiller and BLoe September 30, 2021 19:30
@fregante

This comment has been minimized.

Sign in to view
@BALEHOK

This comment has been minimized.

Sign in to view
@fregante
Copy link
Contributor

fregante commented Oct 1, 2021

#1549 (comment)

fregante
fregante reviewed Oct 1, 2021
View reviewed changes
package.json Show resolved Hide resolved
@fregante fregante mentioned this pull request Oct 2, 2021
Closed
@cheap-glitch cheap-glitch mentioned this pull request Oct 3, 2021
Merged
BLoe
BLoe suggested changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@BLoe BLoe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I'm seeing a UI issue where the footer doesn't pin to the bottom of the side bar:

image

@BALEHOK BALEHOK requested a review from BLoe October 5, 2021 17:36
@BLoe BLoe merged commit 68a2228 into main Oct 5, 2021
@BLoe BLoe deleted the feature/1475-collapsable-sidebar branch October 5, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante left review comments

@BLoe BLoe BLoe approved these changes

@twschiller twschiller Awaiting requested review from twschiller

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Sidebar in Page Editor collapsable/minimizable
3 participants
@BALEHOK @fregante @BLoe