-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1976 Document Builder Prototype #1999
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
86058c2
Document Builder story shape
BALEHOK 6241834
DocumentEditor and DocumentPreview
BALEHOK 4ce4dc2
Integrating Editor into Edit page
BALEHOK 222de6d
Expressions
BALEHOK b4417e1
Fixing headers generation
BALEHOK f9a9c32
Moving components + datapanel height fix
BALEHOK 73039e2
Creating Grid set
BALEHOK ec89a6a
Example element. Element name. Empty container names
BALEHOK b37a055
Dropdown menu boundary.
BALEHOK d8b956c
Highlight hovered element
BALEHOK 24bc36f
Ignore prettier.xml config
BALEHOK a11eb90
Root container
BALEHOK 46af409
AddElementAction as Ellipsis only
BALEHOK 875c1f4
PR issues
BALEHOK e0a4fe5
PR issues
BALEHOK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Copyright (C) 2021 PixieBrix, Inc. | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
import { buildDocumentBranch } from "@/components/documentBuilder/documentTree"; | ||
import React from "react"; | ||
import ReactShadowRoot from "react-shadow-root"; | ||
import BootstrapStylesheet from "@/blocks/renderers/BootstrapStylesheet"; | ||
import { DocumentViewProps } from "./DocumentViewProps"; | ||
import DocumentContext from "@/components/documentBuilder/DocumentContext"; | ||
|
||
const DocumentView: React.FC<DocumentViewProps> = ({ body, options }) => ( | ||
// Wrap in a React context provider that passes BlockOptions down to any embedded bricks | ||
// ReactShadowRoot needs to be inside an HTMLElement so it has something to attach to | ||
<DocumentContext.Provider value={{ options }}> | ||
<div className="h-100"> | ||
<ReactShadowRoot> | ||
<BootstrapStylesheet /> | ||
{body.map((documentElement, i) => { | ||
const { Component, props } = buildDocumentBranch(documentElement); | ||
return <Component key={i} {...props} />; | ||
})} | ||
</ReactShadowRoot> | ||
</div> | ||
</DocumentContext.Provider> | ||
); | ||
|
||
export default DocumentView; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
* Copyright (C) 2021 PixieBrix, Inc. | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as published by | ||
* the Free Software Foundation, either version 3 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
*/ | ||
|
||
import React, { Suspense } from "react"; | ||
import { DocumentViewProps } from "./DocumentViewProps"; | ||
|
||
// Dynamic import because documentView has a transitive dependency of react-shadow-root which assumed a proper | ||
// `window` variable is present on module load. This isn't available on header generation | ||
const DocumentView = React.lazy( | ||
async () => | ||
import( | ||
/* webpackChunkName: "document-view" */ | ||
"./DocumentView" | ||
) | ||
); | ||
|
||
const DocumentViewLazy: React.FC<DocumentViewProps> = (props) => ( | ||
<Suspense fallback={<div className="text-muted">Loading...</div>}> | ||
<DocumentView {...props} /> | ||
</Suspense> | ||
); | ||
|
||
export default DocumentViewLazy; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { DocumentElement } from "@/components/documentBuilder/documentBuilderTypes"; | ||
import { BlockArgContext, BlockOptions } from "@/core"; | ||
|
||
export type DocumentViewProps = { | ||
body: DocumentElement[]; | ||
options: BlockOptions<BlockArgContext>; | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what is this for? I know we also have something similar in our Jest configuration? Add a comment for what this is needed for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default webpack doesn't know how to load
.scss
files. The loader we use for the app will generate an object with class names (those weird hashes) as values, for Jest and Headers since we don't care about actual class names we can use "identity-obj-proxy" - an object that will return the property name for any property asked (obj.prop === 'prop'; obj.textSuccess === 'textSuccess').