Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Rollbar-native .cause support for improved display #3177

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Use Rollbar-native .cause support for improved display #3177

merged 3 commits into from
Apr 18, 2022

Conversation

fregante
Copy link
Contributor

The new library detects the two errors separately:

Screen Shot 3

And are displayed this way:

Screen Shot 8

This PR can be merged, but two more improvements will let us drop more workarounds I had implemented:

@fregante fregante marked this pull request as ready for review April 17, 2022 13:17
@twschiller twschiller merged commit 810f9b4 into main Apr 18, 2022
@twschiller twschiller deleted the F/errors/native-cause branch April 18, 2022 14:21
@twschiller twschiller added this to the 1.6.0 milestone Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twschiller twschiller twschiller approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fregante @twschiller