Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3385: Use default theme logo when not found #3386

Closed
wants to merge 4 commits into from
Closed

Conversation

fregante
Copy link
Contributor

What does this PR do?

Discussion

  • Is this the right place where this should be fixed?

Before

Screen Shot

After

Screen Shot 3

Future Work

@fregante fregante requested a review from mnholtz May 14, 2022 07:28
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2022

Codecov Report

Merging #3386 (9c4bdca) into main (44225b6) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #3386   +/-   ##
=======================================
  Coverage   37.65%   37.66%           
=======================================
  Files         755      755           
  Lines       21805    21801    -4     
  Branches     4651     4651           
=======================================
  Hits         8211     8211           
+ Misses      12669    12666    -3     
+ Partials      925      924    -1     
Impacted Files Coverage Δ
src/hooks/useTheme.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44225b6...9c4bdca. Read the comment docs.

@fregante
Copy link
Contributor Author

Closing in favor of #3384

@fregante fregante closed this May 14, 2022
@fregante fregante deleted the F/bug/logo-is-null branch May 14, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension is broken for new installs
2 participants