Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve e2e test docs and error handling #8214

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Improve e2e test docs and error handling #8214

merged 4 commits into from
Apr 10, 2024

Conversation

fungairino
Copy link
Collaborator

@fungairino fungairino commented Apr 10, 2024

What does this PR do?

  • Updates the readme with more accurate setup step info
  • Removes the skip local auth functionality in the config. Instead, you can use the filter functionality in UI mode. This makes skipping the auth project more intentional to avoid issues with lingering auth profiles.
  • Adds better error logging when the auth profile directory files are missing

Future Work

Why does UI mode not show the latest results??? 🤬

Checklist

  • Add jest or playwright tests and/or storybook stories
  • Designate a primary reviewer @mnholtz

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Upgrade once this issue fix is released: microsoft/playwright#30312
@fungairino fungairino enabled auto-merge (squash) April 10, 2024 19:09
@fungairino fungairino merged commit 9a44d41 into main Apr 10, 2024
19 of 20 checks passed
@fungairino fungairino deleted the e2e-tweaks branch April 10, 2024 19:15
@twschiller twschiller added this to the 1.8.13 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants