Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot manual updates #9509

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Dependabot manual updates #9509

merged 9 commits into from
Nov 12, 2024

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

For more information on our expectations for the PR process, see the
code review principles doc

@@ -224,6 +224,7 @@
"@types/object-hash": "^3.0.6",
"@types/papaparse": "^5.3.15",
"@types/psl": "^1.1.3",
"@types/react": "^17.0.83",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the react-select typings

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller
Copy link
Contributor

@grahamlangford see typescript errors in upload-lexicon

@twschiller twschiller added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

Playwright test results

passed  151 passed
flaky  3 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  11 minutes, 4 seconds
commit  7644fb8
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
msedge › tests/telemetry/errors.spec.ts › can report an indexdb error to telemetry service

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.80%. Comparing base (8318d74) to head (7644fb8).
Report is 495 commits behind head on main.

Files with missing lines Patch % Lines
...rowser-extension/src/store/sidebar/sidebarSlice.ts 80.00% 3 Missing ⚠️
...tension/src/pageEditor/store/editor/editorSlice.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9509      +/-   ##
==========================================
+ Coverage   74.24%   75.80%   +1.55%     
==========================================
  Files        1332     1422      +90     
  Lines       40817    42913    +2096     
  Branches     7634     7899     +265     
==========================================
+ Hits        30306    32530    +2224     
+ Misses      10511    10383     -128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -235,6 +236,7 @@
"@types/redux-state-sync": "^3.1.10",
"@types/semver": "^7.5.8",
"@types/sinonjs__fake-timers": "^8.1.5",
"@types/trusted-types": "^2.0.7",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the duplicate typing mixpanel lexicon issue

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this casting is from a chain of type issues:

  1. react-select pushed a breaking type change as a patch to support React 19: Fix types compatibility with React 19 JedWatson/react-select#5974
  2. To fix the breaking type change, I installed @types/react, which caused the TrustedHTML issue with the mixpanel lexicon: [@types/react] - TrustedHTML defined in multiple places error when using react-scripts DefinitelyTyped/DefinitelyTyped#65701
  3. To fix the TrustedHTML issue, I installed @types/trusted-types, which caused our helpers and selectors to throw errors in our slices due to passing WritableDrafts as regular state

There may be another way to solve the mixpanel lexicon issue, but also the type errors are technically correct. Thoughts?

@twschiller twschiller added this to the 2.2.0 milestone Nov 12, 2024
@grahamlangford grahamlangford enabled auto-merge (squash) November 12, 2024 23:32
@grahamlangford grahamlangford merged commit a017277 into main Nov 12, 2024
22 checks passed
@grahamlangford grahamlangford deleted the dependabot-manual-updates branch November 12, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

3 participants