-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependabot manual updates #9509
Conversation
@@ -224,6 +224,7 @@ | |||
"@types/object-hash": "^3.0.6", | |||
"@types/papaparse": "^5.3.15", | |||
"@types/psl": "^1.1.3", | |||
"@types/react": "^17.0.83", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the react-select typings
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
@grahamlangford see typescript errors in upload-lexicon |
Playwright test resultsDetails Open report ↗︎ Flaky testschrome › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9509 +/- ##
==========================================
+ Coverage 74.24% 75.80% +1.55%
==========================================
Files 1332 1422 +90
Lines 40817 42913 +2096
Branches 7634 7899 +265
==========================================
+ Hits 30306 32530 +2224
+ Misses 10511 10383 -128 ☔ View full report in Codecov by Sentry. |
…dependabot-manual-updates
@@ -235,6 +236,7 @@ | |||
"@types/redux-state-sync": "^3.1.10", | |||
"@types/semver": "^7.5.8", | |||
"@types/sinonjs__fake-timers": "^8.1.5", | |||
"@types/trusted-types": "^2.0.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the duplicate typing mixpanel lexicon issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of this casting is from a chain of type issues:
- react-select pushed a breaking type change as a patch to support React 19: Fix types compatibility with React 19 JedWatson/react-select#5974
- To fix the breaking type change, I installed
@types/react
, which caused the TrustedHTML issue with the mixpanel lexicon: [@types/react] - TrustedHTML defined in multiple places error when using react-scripts DefinitelyTyped/DefinitelyTyped#65701 - To fix the TrustedHTML issue, I installed
@types/trusted-types
, which caused our helpers and selectors to throw errors in our slices due to passingWritableDraft
s as regular state
There may be another way to solve the mixpanel lexicon issue, but also the type errors are technically correct. Thoughts?
What does this PR do?
For more information on our expectations for the PR process, see the
code review principles doc