POC: JavaScript expressions in brick args #9510
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
javascript
expression typeGaps
@
is not valid in JS identifiers. (It's also a bad character because@
toggles username popups in many collaboration tools)$vars
object, e.g.,$vars["@input.url"].length
@<ident>
to$vars["<ident>"]
automatically. That's what val.town used to do (IIRC, they used a custom babel plugin to do that). They then moved to vanilla JS syntax to better benefit from the JS tooling ecosystemDemo
For more information on our expectations for the PR process, see the
code review principles doc