#9493 Add Image Button to Rich Text Editor #9513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # applications/browser-extension/package.json # applications/browser-extension/src/components/richTextEditor/RichTextEditor.tsx # applications/browser-extension/src/components/richTextEditor/toolbar/Toolbar.tsx
twschiller
reviewed
Nov 13, 2024
...ations/browser-extension/src/components/richTextEditor/toolbar/ImageButton/useUploadAsset.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This and similar changes was required due to updating the swagger.ts
…xiebrix/pixiebrix-extension into feature/9493_add_image_button merge grahams changes
Comment on lines
249
to
275
| axiosMock.onPost(API_PATHS.ASSET_PRE_UPLOAD(databaseId)).reply(200, { | ||
| asset: { | ||
| id: assetId, | ||
| download_url: mockDownloadUrl.href, | ||
| filename: file.name, | ||
| is_uploaded: false, | ||
| updated_at: new Date().toISOString(), | ||
| created_at: new Date().toISOString(), | ||
| }, | ||
| upload_url: mockUploadUrl.href, | ||
| fields: { | ||
| key: "test-key", | ||
| policy: "test-policy", | ||
| }, | ||
| }); | ||
|
|
||
| axiosMock.onPost(mockUploadUrl.href).reply(200); | ||
|
|
||
| // Mock the asset update request | ||
| axiosMock.onPatch(API_PATHS.ASSET(databaseId, assetId)).reply(200, { | ||
| id: assetId, | ||
| download_url: mockDownloadUrl.href, | ||
| filename: file.name, | ||
| is_uploaded: true, | ||
| updated_at: new Date().toISOString(), | ||
| created_at: new Date().toISOString(), | ||
| }); |
There was a problem hiding this comment.
NIT:
Suggested change
| axiosMock.onPost(API_PATHS.ASSET_PRE_UPLOAD(databaseId)).reply(200, { | |
| asset: { | |
| id: assetId, | |
| download_url: mockDownloadUrl.href, | |
| filename: file.name, | |
| is_uploaded: false, | |
| updated_at: new Date().toISOString(), | |
| created_at: new Date().toISOString(), | |
| }, | |
| upload_url: mockUploadUrl.href, | |
| fields: { | |
| key: "test-key", | |
| policy: "test-policy", | |
| }, | |
| }); | |
| axiosMock.onPost(mockUploadUrl.href).reply(200); | |
| // Mock the asset update request | |
| axiosMock.onPatch(API_PATHS.ASSET(databaseId, assetId)).reply(200, { | |
| id: assetId, | |
| download_url: mockDownloadUrl.href, | |
| filename: file.name, | |
| is_uploaded: true, | |
| updated_at: new Date().toISOString(), | |
| created_at: new Date().toISOString(), | |
| }); | |
| axiosMock.onPost(API_PATHS.ASSET_PRE_UPLOAD(databaseId)).reply(200, { | |
| asset: { | |
| id: assetId, | |
| download_url: mockDownloadUrl.href, | |
| filename: file.name, | |
| is_uploaded: false, | |
| updated_at: new Date().toISOString(), | |
| created_at: new Date().toISOString(), | |
| }, | |
| upload_url: mockUploadUrl.href, | |
| fields: { | |
| key: "test-key", | |
| policy: "test-policy", | |
| }, | |
| }).onPost(mockUploadUrl.href) | |
| .reply(200) | |
| // Mock the asset update request | |
| .onPatch(API_PATHS.ASSET(databaseId, assetId)).reply(200, { | |
| id: assetId, | |
| download_url: mockDownloadUrl.href, | |
| filename: file.name, | |
| is_uploaded: true, | |
| updated_at: new Date().toISOString(), | |
| created_at: new Date().toISOString(), | |
| }); |
grahamlangford
approved these changes
Nov 14, 2024
|
When the PR is merged, the first loom link found on this PR will be posted to |
…xiebrix/pixiebrix-extension into feature/9493_add_image_button merge origin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Discussion
Demo
https://www.loom.com/share/e0761bba8c0244dd98223f02a346f86b