Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rainforest and sourcemaps upload scripts #9518

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

grahamlangford
Copy link
Collaborator

@grahamlangford grahamlangford commented Nov 13, 2024

What does this PR do?

  • Fixes path in upload scripts to account for workspace

For more information on our expectations for the PR process, see the
code review principles doc

@grahamlangford grahamlangford changed the title fix rainforest upload fix rainforest and sourcemaps upload scripts Nov 13, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller added this to the 2.2.0 milestone Nov 13, 2024
@grahamlangford grahamlangford merged commit 8334de1 into main Nov 13, 2024
9 checks passed
@grahamlangford grahamlangford deleted the fix-rainforest-upload branch November 13, 2024 14:58
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.80%. Comparing base (8318d74) to head (7798544).
Report is 500 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9518      +/-   ##
==========================================
+ Coverage   74.24%   75.80%   +1.55%     
==========================================
  Files        1332     1422      +90     
  Lines       40817    42913    +2096     
  Branches     7634     7899     +265     
==========================================
+ Hits        30306    32530    +2224     
+ Misses      10511    10383     -128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results

passed  151 passed
flaky  3 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  11 minutes, 2 seconds
commit  7798544
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge › tests/pageEditor/saveMod.spec.ts › shows error notification when updating a public mod without incrementing the version
msedge › tests/runtime/modVariables/variableSync.spec.ts › Mod Variable Sync › session variable cross-tab sync
chrome › tests/runtime/sidebar/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants