Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display property on RichTextEditor error toast #9525

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

mnholtz
Copy link
Collaborator

@mnholtz mnholtz commented Nov 15, 2024

What does this PR do?

  • Quickfix for an issue that @Pashaminkovsky noticed were the toast notification for displaying rich text editor errors was getting the wrong display property when hidden, preventing mouse-clicking into the editor in the bottom-left corner

Demo

Fixes this issue 👇

image

@mnholtz mnholtz added the bug Something isn't working label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.78%. Comparing base (8318d74) to head (f0e6685).
Report is 509 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9525      +/-   ##
==========================================
+ Coverage   74.24%   75.78%   +1.53%     
==========================================
  Files        1332     1427      +95     
  Lines       40817    43048    +2231     
  Branches     7634     7916     +282     
==========================================
+ Hits        30306    32622    +2316     
+ Misses      10511    10426      -85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results

passed  153 passed
flaky  1 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  10 minutes, 26 seconds
commit  f0e6685
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@grahamlangford grahamlangford added this to the 2.2.0 milestone Nov 15, 2024
@grahamlangford grahamlangford merged commit 1b01808 into main Nov 15, 2024
24 checks passed
@grahamlangford grahamlangford deleted the bugfix/hide_toast_element branch November 15, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants