Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: meshes squashed after changing anim state #385

Closed
wants to merge 1 commit into from
Closed

BUGFIX: meshes squashed after changing anim state #385

wants to merge 1 commit into from

Conversation

aapavlov1994
Copy link

I have a bug with squashing mesh attachments when try to change animation state. it reproduced with

animations made with spine v3.8.99
pixi.js: 6.0.2
pixi-spine: >= 2.1.10

So, i compared 2.1.10 and 2.1.11 versions and i think that found and fixed source of this bug.

@ivanpopelyshev
Copy link
Collaborator

ivanpopelyshev commented Apr 22, 2021

Its copied from https://github.com/EsotericSoftware/spine-runtimes/blob/3.8/spine-ts/core/src/AnimationState.ts#L381 . Can you explain what is wrong there and re-post it to spine-runtimes?

maybe test the same bug in spine-ts runtime

@aapavlov1994
Copy link
Author

Okay, i'll redirect PR to EsotericSoftware/spine-runtimes then.
P.S. bug representation:
expectation - 2.1.10 package and build with my fixes
good
reality - >= 2.1.10 packages
bad

@aapavlov1994
Copy link
Author

They merged it!

@aapavlov1994
Copy link
Author

@ivanpopelyshev Can you patch your "next" branch by this?

@ivanpopelyshev
Copy link
Collaborator

Good idea, i will do it tomorrow )

@ivanpopelyshev
Copy link
Collaborator

Actually, its now in master, i wil remove next soon )

@ivanpopelyshev
Copy link
Collaborator

Done, 3.0.0 is released, you can also ditch window.PIXI :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants