Issue checkstyle#13213: Removed //ok from magicNumber

piyush-1234 · Jan 17, 2024 · 0ee4402 · 0ee4402
1 parent 671e9cc
commit 0ee4402
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/config/checkstyle-input-suppressions.xml b/config/checkstyle-input-suppressions.xml
@@ -78,12 +78,6 @@
             files="checks[\\/]coding[\\/]illegaltokentext[\\/]InputIllegalTokenTextTextBlocks.java"/>
   <suppress id="UnnecessaryOkComment"
             files="checks[\\/]coding[\\/]illegaltokentext[\\/]InputIllegalTokenTextTextBlocks.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]magicnumber[\\/]InputMagicNumberIgnoreFieldDeclarationRecords.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]magicnumber[\\/]InputMagicNumberIgnoreFieldDeclarationRecords.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]coding[\\/]magicnumber[\\/]InputMagicNumberIgnoreFieldDeclarationRecords.java"/>
   <suppress id="UnnecessaryOkComment"
             files="checks[\\/]coding[\\/]nofinalizer[\\/]InputNoFinalizerFallThrough.java"/>
   <suppress id="UnnecessaryOkComment"

diff --git a/...s/checkstyle/checks/coding/magicnumber/InputMagicNumberIgnoreFieldDeclarationRecords.java b/...s/checkstyle/checks/coding/magicnumber/InputMagicNumberIgnoreFieldDeclarationRecords.java
@@ -18,7 +18,7 @@
 public class InputMagicNumberIgnoreFieldDeclarationRecords {
     @anno(6) // violation
     public record MyRecord() {
-        private static int myInt = 7; // ok
+        private static int myInt = 7;
 
         public MyRecord{
             int i = myInt + 1; // no violation, 1 is defined as non-magic
@@ -41,9 +41,9 @@ public int hashCode() {
 }
 
 class TestClass {
-    static int X = 42; // ok
+    static int X = 42;
 }
 
 record TestRecord() {
-    static int X = 42; // ok
+    static int X = 42;
 }