Fix retry handling + Add support for CoA and Disconnect Packets + VSA Reply Parsing Support #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keyword collision for value.id fixed with attr_accessor ...
… accounting response authenticator generation
…dation, and aliased gen_auth_response_authenticator to gen_acct_response_authenticator.
… name is 'Vendor/Attribute' ie 'Cisco/Cisco/Cisco-AVPair'.
Some attributes were getting missed if the packet was over 64 bytes Upped max packet size to 4096 as per rfc Added in exception if read packet size != declared size
When a packet is retranmitted it should use the same ID so the server can detect it as a retransmission, if it was the reply that was lost. Also, dont decrement the configured retries for the request channel so the same socket and connection can be used for multiple requests.
They should be sent to the CoA port 3799
|
Thanks everyone for the contributions! I pushed a new version of the gem with these changes just now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the large amount of changes here, but I had based off a different fork
This fixes some other bugs too such as Packet Truncation