Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store): Make stamp optional #52

Merged
merged 3 commits into from
Jul 24, 2023
Merged

feat(store): Make stamp optional #52

merged 3 commits into from
Jul 24, 2023

Conversation

pjechris
Copy link
Owner

⚽️ Description

Because most people won't use stamp, and that stamp can be anyway kind of Double, make it optional by default. New behavior will be:

  • if stamp is nil: accept the update no matter what.

🔨 Implementation details

  • Remove default stamp value and make it optional
  • When stamp is nil, update is applied to EntityNode no matter what

@pjechris pjechris added the feature New feature or request label Jul 24, 2023
@pjechris pjechris merged commit 6fb3e74 into main Jul 24, 2023
2 checks passed
@pjechris pjechris deleted the feat/stamp-optional branch July 24, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pjechris