tech(store): Ignore multiple changes to same entity while storing/updating #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚽️ Description
Part of #48. Now if an entity is changed multiple times while storing it will be change only once (the first time).
This can happen when inserting multiple items at the time (
store(entities:)) or if, for some reason, an aggregate would reference the same object multiple times.🔨 Implementation details
applyChildrenChanges: it was now useless as we remove all children relations before doing any updateObservationRegistryto check if a node was already modified during the transaction. If it's the case: ignore subsequent changes.