Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch LibreSSL code path to utilizing OpenSSL 1.1 API #3758

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Switch LibreSSL code path to utilizing OpenSSL 1.1 API #3758

merged 1 commit into from
Dec 12, 2023

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Nov 2, 2023 •
edited
Loading

Not worrying about version checks as these API additions date back to
LibreSSL 2.7 from almost 6 years ago.

@sauwming
Copy link
Member

sauwming commented Nov 2, 2023

Perhaps some description about why this is necessary?

@sauwming sauwming requested a review from trengginas November 3, 2023 04:23
@nanangizz
Copy link
Member

Perhaps LibreSSL version check is also needed now?

@nanangizz nanangizz added this to the release-2.15 milestone Nov 16, 2023
@brad0
Switch LibreSSL code path to utilizing OpenSSL 1.1 API
9d876ff 
Not worrying about version checks as these API additions date back to
LibreSSL 2.7 from almost 6 years ago.
@brad0 brad0 changed the title Fix building with modern LibreSSL Switch LibreSSL code path to utilizing OpenSSL 1.1 API Dec 10, 2023
@brad0
Copy link
Contributor Author

brad0 commented Dec 10, 2023

I updated the commit message and description to provide more information.

nanangizz
nanangizz approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@nanangizz nanangizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, 6 year old for a TLS/security lib should be quite dated.

@sauwming sauwming merged commit 4140143 into pjsip:master Dec 12, 2023
28 of 35 checks passed
@brad0 brad0 deleted the libressl_fix branch December 12, 2023 05:25
xhit pushed a commit to xhit/pjproject that referenced this pull request Dec 18, 2023
@brad0 @xhit
Switch LibreSSL code path to utilizing OpenSSL 1.1 API (pjsip#3758)
3f7cb0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanangizz nanangizz nanangizz approved these changes

@sauwming sauwming sauwming approved these changes

@trengginas trengginas Awaiting requested review from trengginas

Assignees
No one assigned
Labels
component: pjlib type: enhancement
Projects
None yet
Milestone
release-2.15
Development

Successfully merging this pull request may close these issues.
3 participants
@brad0 @sauwming @nanangizz