fix(render) #71
Merged
fix(render) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Is this possibly related to why our submission of tea to brew didn't work? If so is this a bug in deno? |
|
It doesn't look like the problem in homebrew (I don't see any references to codesigning failing mac or rpath issues on linux). I believe the bug is with Deno (see denoland/deno#11154 for the deepest dive). The fact that a very similar bug seems to exist in Zig makes me think if maybe it's a rust or a rust-misuse issue. |
jhheider
added a commit
to pkgxdev/pantry
that referenced
this pull request
May 3, 2023
* wip * wip * wip * wip * this works, if pkgxdev/brewkit#71 merges * Update package.yml --------- Co-authored-by: Jacob Heider <jacob@tea.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either Deno or Apple is annoying me. Light reading in no specific order:
deno compiledon't pass strict MachO validation on macOS denoland/deno#17753This is basically going to prevent +render pantry#480 from functioning on Mac; possibly every other Deno compiled binary (tea also fails validation, though it does sign). Zig binaries seem to be similarly affected.