-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'swift' #4840
add 'swift' #4840
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job
Ideally we’d avoid resigning this since Apple signed it. Also: I assume we have license to redistribute, but one day we may find out we didn’t. |
since it is downloaded by the user from the https://swift.org it's not really distributed by pkgx, or is it? |
It is distributed by us. The build script runs on our infra to convert everything into bottles that pkgx then downloads from our hosting. |
right, I assume it all is under Apache 2.0 as it states on https://www.swift.org/download/ let's assume that ;) |
@mxcl I'd like you to weigh in on Linux support. I lack the skills how to make it "per distribution" only for a vendored package |
@krzyzanowskim distributions for a specific hardware platform are (almost always) just variations on underlying deps. So if Apple provide a swift for ubuntu where the ubuntu glibc matches our requirements (v23 I think) then it'll be fine. We provide the other dependencies and it should just work at runtime. Failing that we have to build from source. Though once we finish packaging glibc (#147) that issue could also be alleviated. Important I say all this but distributions can do bad things with underlying dependencies that cause binaries built for them to |
Vendored Swift packages for Darwin and Linux; however, the Linux platform is disabled for now due to platform requirement: ubuntu 22.04. Unless somebody can make it run tests on Ubuntu