Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'swift' #4840

Merged
merged 6 commits into from
Jan 17, 2024
Merged

add 'swift' #4840

merged 6 commits into from
Jan 17, 2024

Conversation

krzyzanowskim
Copy link
Contributor

@krzyzanowskim krzyzanowskim commented Jan 14, 2024

Vendored Swift packages for Darwin and Linux; however, the Linux platform is disabled for now due to platform requirement: ubuntu 22.04. Unless somebody can make it run tests on Ubuntu

@krzyzanowskim

This comment was marked as resolved.

@krzyzanowskim krzyzanowskim marked this pull request as ready for review January 14, 2024 20:22
@jhheider jhheider requested a review from mxcl January 15, 2024 02:34
Copy link
Member

@mxcl mxcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

@mxcl
Copy link
Member

mxcl commented Jan 17, 2024

Ideally we’d avoid resigning this since Apple signed it.

Also: I assume we have license to redistribute, but one day we may find out we didn’t.

@mxcl mxcl merged commit 231e832 into pkgxdev:main Jan 17, 2024
5 checks passed
@krzyzanowskim krzyzanowskim deleted the new/swift.org branch January 17, 2024 11:03
@krzyzanowskim
Copy link
Contributor Author

I assume we have license to redistribute

since it is downloaded by the user from the https://swift.org it's not really distributed by pkgx, or is it?

@mxcl
Copy link
Member

mxcl commented Jan 17, 2024

It is distributed by us. The build script runs on our infra to convert everything into bottles that pkgx then downloads from our hosting.

@krzyzanowskim
Copy link
Contributor Author

right, I assume it all is under Apache 2.0 as it states on https://www.swift.org/download/ let's assume that ;)

@krzyzanowskim
Copy link
Contributor Author

@mxcl I'd like you to weigh in on Linux support. I lack the skills how to make it "per distribution" only for a vendored package

@mxcl
Copy link
Member

mxcl commented Jan 17, 2024

@krzyzanowskim distributions for a specific hardware platform are (almost always) just variations on underlying deps. So if Apple provide a swift for ubuntu where the ubuntu glibc matches our requirements (v23 I think) then it'll be fine. We provide the other dependencies and it should just work at runtime.

Failing that we have to build from source.

Though once we finish packaging glibc (#147) that issue could also be alleviated.

Important

I say all this but distributions can do bad things with underlying dependencies that cause binaries built for them to
become extremely specific. Off hand I don't recall ever seeing this, but I'm sure it has happened.

@mxcl mxcl mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants