Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+modernc.org/goyacc #7864

Merged
merged 4 commits into from
Nov 10, 2024
Merged

+modernc.org/goyacc #7864

merged 4 commits into from
Nov 10, 2024

Conversation

tannevaled
Copy link
Contributor

No description provided.

@tannevaled
Copy link
Contributor Author

is there an equivalent to {{prefix}} like {{testbed}} to do not ship the tests files?

@jhheider
Copy link
Contributor

jhheider commented Nov 9, 2024

is there an equivalent to {{prefix}} like {{testbed}} to do not ship the tests files?

no... it's $PWD in the test script. if you want to run go test in the source directory, you need to do it in the build step (build files aren't available at test time).

you can also use curl or git to retrieve test files, like gobject-introspection and others do.

@tannevaled
Copy link
Contributor Author

is there an equivalent to {{prefix}} like {{testbed}} to do not ship the tests files?

no... it's $PWD in the test script. if you want to run go test in the source directory, you need to do it in the build step (build files aren't available at test time).

you can also use curl or git to retrieve test files, like gobject-introspection and others do.

ok. is it possible to have something like {{distributable.url}} to not repeat something already done?

...
+ cd /root/work/pkgxdev-pantry-goyacc/testbeds/modernc.org__goyacc-1.0.3
+ git clone '{{distributable.url}}' test
fatal: repository '{{distributable.url}}' does not exist

@jhheider
Copy link
Contributor

ok. is it possible to have something like {{distributable.url}} to not repeat something already done?

It could be possible, that would be something like reading in the yaml itself into https://github.com/pkgxdev/libpkgx/blob/main/src/hooks/useMoustaches.ts .

Generally, tests that are built into the build source are tested at build time, rather than test time (so, run go test in the build script, e.g. make check in libpaper). And the test script should do its best to ensure that the installed binary is working correctly, ideally.

@jhheider jhheider merged commit e8b4b4b into pkgxdev:main Nov 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants