Halve runtime when simplifying large lines #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, let me say thank you for putting together this library—it saved us a ton of time in our project. 🙏
This PR dramatically improves performance on lines with a large number of points, primarily by reducing the number of times we have to iterate over the list.
length/1
, since it's linear in the size of the listThis also adds a very simple benchmark to the test suite, which can be run with:
Benchmarks on my machines (both running Elixir 13.4 + OTP 24, so the Intel machine has the benefit of the JIT):