Set Window isHidden to True on Init #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the tests pass when testing locally. I am changing the time interval on the tests to address the CI time-out failure. |
PGLongo
requested changes
May 9, 2017
PGLongo
approved these changes
May 9, 2017
|
Unfortunately there are still problems with Travis. I should investigate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When HUD first get initialized, it is not hidden. As a result, checking
HUD.isVisiblereturns true even though it has never been presented. SettingisHiddentotrueonWindow.swiftresolves this.The particular case I am addressing is for deeplinking into an app. I only want to proceed with the deep link if there is not a non-interruptible operation in progress (easily identified by a visible HUD).