Add retry mechanism #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before there were 2 separate fn calls in the 'src/main.rs' module:
let session = context::connect(conf).await?;
let session = Context::new(session);
With this change we simplify it the way that we will do only one call:
let session = context::connect(conf).await?;
vponomaryov
force-pushed
the
add-retries
branch
from
32b692d
to
e23e1d0
Compare
With this change it is now possible to configure retry approach for queries. Following new options are available: --retry-number=10 --retry-interval=200ms | --retry-interval=100ms,3s --request-timeout=5 The '--retry-number' option allows to configure number of retries to be applied in case of query failures. Default is '10'. The '--retry-interval' option may store one or two time values separated with comma. Values may have 'ms' (milliseconds), 's' (seconds) units. If 2 are specified then it will be 'minimum' and 'maximum' waiting interval with exponential growth based on the made attempts. Default is '100ms,5s'. The '--request-timeout' allows to configure the time for a query after which it is considered as 'failed'. Measured in seconds. Default is '5'. Print only 5 retry error messages per sample interval. Also, hide long 'string' and 'blob' values from the retry error messages.
vponomaryov
force-pushed
the
add-retries
branch
from
e23e1d0
to
6cb6722
Compare
|
@pkolaczk seems to fit nicely ontop a fitting tool :) we really liked it's approche and flexibility (and the fact it's built ontop of scylla rust driver) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change it is now possible to configure retry approach for queries.
Following new options are available:
The
--retry-numberoption allows to configure number of retries to be appliedin case of query failures. Default is
10.The
--retry-intervaloption may store one or two time values separated with comma.Values may have
ms(milliseconds),s(seconds) units.If 2 are specified then it will be
minimumandmaximumwaiting intervalwith exponential growth based on the made attempts. Default is
100ms,5s.The
--request-timeoutallows to configure the time for a query after whichit is considered as 'failed'. Measured in seconds. Default is
5.Print only 5 retry error messages per sample interval.
Also, hide long
stringandblobvalues from the retry error messages.Closes: #60