Improved sampling #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously switching to the next sample could only happen at the moment of completing a cycle. If the db didn't respond for a longer period of time, the samples collected were of unequal sizes or weren't recorded at all. Now the timer for sampling (chunking) ticks independently of the workload progress.
pkolaczk
force-pushed
the
better-batching
branch
from
5ee90af
to
b209b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously switching to the next sample could only
happen at the moment of completing a cycle. If the db
didn't respond for a longer period of time, the samples
collected were of unequal sizes or weren't recorded at all.
Now the timer for sampling (chunking) ticks independently
of the workload progress.