pkp/pkp-lib#7505 Review Fixes

pkp · Nov 25, 2023 · 1dd56a1 · 1dd56a1
1 parent d28b4b3
commit 1dd56a1
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/classes/ArticleFront.php b/classes/ArticleFront.php
@@ -91,9 +91,8 @@ public function createJournalMeta(Journal $journal, PKPRequest $request): \DOMNo
                 ->setAttribute('pub-type','ppub');
         }
 
-        $dispatcher = new Dispatcher();
-        $dispatcher->setApplication(Application::get());
-        $dispatcher->addRouterName('\APP\core\PageRouter', PKPApplication::ROUTE_PAGE);
+        $router = $request->getRouter();
+        $dispatcher = $router->getDispatcher();
 
         $journalUrl = $dispatcher->url($request, PKPApplication::ROUTE_PAGE, $journal->getPath());
         $journalMetaElement
@@ -204,7 +203,7 @@ function createArticleMeta(Submission $submission, Journal $journal, Section $se
         }
 
         // Include pub dates
-        if ($datePublished){
+        if ($datePublished) {
             $pubDateElement = $articleMetaElement->appendChild($this->createElement('pub-date'))
                 ->setAttribute('date-type', 'pub')->parentNode
                 ->setAttribute('publication-format','epub')->parentNode;
@@ -217,8 +216,6 @@ function createArticleMeta(Submission $submission, Journal $journal, Section $se
 
             $pubDateElement->appendChild($this->createElement('year'))
                 ->appendChild($this->createTextNode(strftime('%Y', (int)$datePublished)));
-        } else {
-            $pubDateElement = $articleMetaElement->appendChild($this->createElement('pub-date-not-available'));
         }
 
         // Include page info, if available and parseable.
@@ -281,9 +278,9 @@ function createArticleMeta(Submission $submission, Journal $journal, Section $se
             }
         }
 
-        $dispatcher = new Dispatcher();
-        $dispatcher->setApplication(Application::get());
-        $dispatcher->addRouterName('\APP\core\PageRouter', PKPApplication::ROUTE_PAGE);
+        $router = $request->getRouter();
+        $dispatcher = $router->getDispatcher();
+
         $url = $dispatcher->url($request, PKPApplication::ROUTE_PAGE, $journal->getPath(), 'article', 'view', $submission->getBestId(), null, null, true);
 
         $articleMetaElement