[JatsTemplate][main] #7505 Initial Commit Upload - Delete - Download JATS File #41
Conversation
classes/Article.php
Outdated
| $this->convertToXml($record); | ||
|
|
||
| if ($record) { | ||
| $this->convertToXml($record); |
There was a problem hiding this comment.
I'd suggest moving this call outside of the constructor entirely; let the existing (JATSTemplatePlugin) use case call an additional function to perform the conversion, just like you've done for the new use case. (Call it e.g. convertToOai.)
There was a problem hiding this comment.
My first instinct was also to remove it - on second thought, and because the constructor is being used in a way that I couldn't figure out why (but accepting that it has a reason), I followed this "safe" way.
I will refactor it.
classes/Article.php
Outdated
| @@ -37,25 +41,34 @@ public function convertToXml($record) :bool|\DOMDocument | |||
| $publication = $submission->getCurrentPublication(); | |||
| $request = Application::get()->getRequest(); | |||
|
|
|||
| $convertedXML = $this->convertSubmission($submission, $journal, $section, $issue, $publication, $request); | |||
|
|
|||
| return $this->loadXml($convertedXML); | |||
There was a problem hiding this comment.
It would be nice to cut down on the load/save cycle here; I'm not sure why it was written that way, but I don't think it's necessary.
classes/ArticleFront.php
Outdated
| if ($datePublished) $datePublished = strtotime($datePublished); | ||
|
|
||
| if (!$datePublished) $datePublished = strtotime('0001-01-01'); |
There was a problem hiding this comment.
Is there a way to properly indicate to the JATS output that we don't yet have a publication date?
There was a problem hiding this comment.
Perhaps this. I will refactor the JATS Template
There was a problem hiding this comment.
Fixed
Right now if a publication is assigned to an issue but is not published, a publication date is added to JATS. Not sure if that is correct though - I would expect that if the publication is not yet published, the publication date should be null, and not retrieved by the assigned issue
There was a problem hiding this comment.
It should be possible to omit the pub-date element if the content is not yet published. (JATS reference for article metadata)
There was a problem hiding this comment.
The added pub-date-not-available element is removed
still wondering about that
Right now if a publication is assigned to an issue but is not published, a publication date is added to JATS. Not sure if that is correct though - I would expect that if the publication is not yet published, the publication date should be null, and not retrieved by the assigned issue
There was a problem hiding this comment.
Agreed, the publication date should not be added if the issue is not yet published.
classes/ArticleFront.php
Outdated
|
|
||
| $dispatcher = new Dispatcher(); | ||
| $dispatcher->setApplication(Application::get()); | ||
| $dispatcher->addRouterName('\APP\core\PageRouter', PKPApplication::ROUTE_PAGE); |
There was a problem hiding this comment.
The problem here is that this is called from an API endpoint. The Application::getRequest() returns an APIRouter does not seem to like the url creation with parts other than the necessary for the endpoints.
This was a way to bypass that.
There was a problem hiding this comment.
You should be able to use:
$router = $request->getRouter();
$dispatcher = $router->getDispatcher();
$url = $dispatcher->url(...)...rather than instantiating and configuring your own dispatcher.
There was a problem hiding this comment.
You are right.
Fixed
defstat
force-pushed
the
pkp/pkp-lib#7505
branch
from
4f1391a to
01087dd
Compare
|
Closed in favor of #42 |
No description provided.