Remove deprecated methods and import synbtax

pkp · Nov 15, 2024 · 06e13c1 · 06e13c1
1 parent 01fd215
commit 06e13c1
Showing 1 changed file with 13 additions and 15 deletions.
diff --git a/OAIMetadataFormat_JATS.php b/OAIMetadataFormat_JATS.php
@@ -22,7 +22,6 @@
 use APP\core\Application;
 use APP\issue\IssueAction;
 use PKP\plugins\PluginRegistry;
-use PKP\core\PKPString;
 use PKP\plugins\Hook;
 
 class OAIMetadataFormat_JATS extends OAIMetadataFormat {
@@ -93,7 +92,6 @@ function toXml($record, $format = null) {
 
 		// Check access
 		$request = Application::get()->getRequest();
-		import('classes.issue.IssueAction');
 		$issueAction = new IssueAction();
 		$subscriptionRequired = $issueAction->subscriptionRequired($issue, $journal);
 		$isSubscribedDomain = $issueAction->subscribedDomain(Application::get()->getRequest(), $journal, $issue->getId(), $article->getId());
@@ -165,13 +163,13 @@ protected function _mungeMetadata($doc, $journal, $article, $section, $issue) {
 		$publication = $article->getCurrentPublication();
 
 		$articleNode = $xpath->query('//article')->item(0);
-		$articleNode->setAttribute('xml:lang', substr($article->getLocale(),0,2));
+		$articleNode->setAttribute('xml:lang', substr($article->getData('locale'),0,2));
 		$articleNode->setAttribute('dtd-version', '1.1');
 		$articleNode->setAttribute('specific-use', 'eps-0.1');
 		$articleNode->setAttribute('xmlns', 'https://jats.nlm.nih.gov/publishing/1.1/');
 
 		// Set the article publication date. http://erudit-ps-documentation.readthedocs.io/en/latest/tagset/element-pub-date.html
-		if ($datePublished = $article->getDatePublished()) {
+		if ($datePublished = $publication->getData('datePublished')) {
 			$datePublished = strtotime($datePublished);
 			$match = $xpath->query("//article/front/article-meta/pub-date[@date-type='pub' and @publication-format='epub']");
 			if ($match->length) {
@@ -215,12 +213,12 @@ protected function _mungeMetadata($doc, $journal, $article, $section, $issue) {
 
 		// Set the article URLs: Landing page
 		$uriNode = $this->_addChildInOrder($articleMetaNode, $doc->createElement('self-uri'));
-		$uriNode->setAttribute('xlink:href', $request->url(null, 'article', 'view', $article->getBestArticleId()));
+		$uriNode->setAttribute('xlink:href', $request->url(null, 'article', 'view', [$article->getBestId()]));
 
 		// Set the article URLs: Galleys
 		foreach ($article->getGalleys() as $galley) {
 			$uriNode = $this->_addChildInOrder($articleMetaNode, $doc->createElement('self-uri'));
-			$uriNode->setAttribute('xlink:href', $request->url(null, 'article', 'view', [$article->getBestArticleId(), $galley->getId()]));
+			$uriNode->setAttribute('xlink:href', $request->url(null, 'article', 'view', [$article->getBestId(), $galley->getId()]));
 			if (!$galley->getData('urlRemote')) $uriNode->setAttribute('content-type', $galley->getFileType());
 		}
 
@@ -258,31 +256,31 @@ protected function _mungeMetadata($doc, $journal, $article, $section, $issue) {
 		$titleGroupNode = $xpath->query('//article/front/article-meta/title-group')->item(0);
 		while ($titleGroupNode->hasChildNodes()) $titleGroupNode->removeChild($titleGroupNode->firstChild);
 		$titleNode = $titleGroupNode->appendChild($doc->createElement('article-title'));
-		$titleNode->setAttribute('xml:lang', substr($article->getLocale(),0,2));
+		$titleNode->setAttribute('xml:lang', substr($article->getData('locale'),0,2));
 
 		$articleTitleHtml = $doc->createDocumentFragment();
 		$articleTitleHtml->appendXML(
 			$this->mapHtmlTagsForTitle(
 				$article->getCurrentPublication()->getLocalizedTitle(
-					$article->getLocale(),
+					$article->getData('locale'),
 					'html'
 				)
 			)
 		);
 		$titleNode->appendChild($articleTitleHtml);
 
-		if (!empty($subtitle = $article->getCurrentPublication()->getLocalizedSubTitle($article->getLocale(), 'html'))) {
+		if (!empty($subtitle = $article->getCurrentPublication()->getLocalizedSubTitle($article->getData('locale'), 'html'))) {
 
 			$subtitleHtml = $doc->createDocumentFragment();
 			$subtitleHtml->appendXML($this->mapHtmlTagsForTitle($subtitle));
 
 			$subtitleNode = $titleGroupNode->appendChild($doc->createElement('subtitle'));
-			$subtitleNode->setAttribute('xml:lang', substr($article->getLocale(),0,2));
+			$subtitleNode->setAttribute('xml:lang', substr($article->getData('locale'),0,2));
 
 			$subtitleNode->appendChild($subtitleHtml);
 		}
 		foreach ($article->getCurrentPublication()->getTitles('html') as $locale => $title) {
-			if ($locale == $article->getLocale()) {
+			if ($locale == $article->getData('locale')) {
 				continue;
 			}
 
@@ -333,7 +331,7 @@ protected function _mungeMetadata($doc, $journal, $article, $section, $issue) {
 		foreach ($articleMetaNode->getElementsByTagName('abstract') as $abstractNode) $articleMetaNode->removeChild($abstractNode);
 		foreach ((array) $publication->getData('abstract') as $locale => $abstract) {
 			if (empty($abstract)) continue;
-			$isPrimary = $locale == $article->getLocale();
+			$isPrimary = $locale == $article->getData('locale');
 			$abstractDoc = new \DOMDocument;
 			if (strpos($abstract, '<p>')===null) $abstract = "<p>$abstract</p>";
 			$abstractDoc->loadXML(($isPrimary?'<abstract>':'<trans-abstract>') . $purifier->purify($abstract) . ($isPrimary?'</abstract>':'</trans-abstract>'));
@@ -378,9 +376,9 @@ protected function _mungeMetadata($doc, $journal, $article, $section, $issue) {
 
 		// Override permissions, when not supplied in the document
 		$match = $xpath->query('//article/front/article-meta/permissions');
-		$copyrightHolder = $article->getLocalizedCopyrightHolder($article->getLocale());
-		$copyrightYear = $article->getCopyrightYear();
-		$licenseUrl = $article->getLicenseURL();
+		$copyrightHolder = $publication->getLocalizedData('copyrightHolder', $article->getData('locale'));
+		$copyrightYear = $publication->getData('copyrightYear');
+		$licenseUrl = $publication->getData('licenseUrl');
 		if (!$match->length && ($copyrightHolder || $copyrightYear || $licenseUrl)) {
 			$permissionsNode = $this->_addChildInOrder($articleMetaNode, $doc->createElement('permissions'));
 			if ($copyrightYear || $copyrightHolder) $permissionsNode->appendChild($doc->createElement('copyright-statement'))->appendChild($doc->createTextNode(__('submission.copyrightStatement', ['copyrightYear' => $copyrightYear, 'copyrightHolder' => $copyrightHolder])));