pkp/orcidProfile#322 Unable to submit review data with multilingual s…

…ubmission
pkp · Dec 19, 2024 · baa81a1 · baa81a1
1 parent 235f45e
commit baa81a1
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/classes/orcid/OrcidReview.php b/classes/orcid/OrcidReview.php
@@ -102,9 +102,15 @@ private function build(): array
             $orcidReview['subject-url'] = ['value' => $publicationUrl];
             $orcidReview['review-url'] = ['value' => $publicationUrl];
             $orcidReview['subject-type'] = 'journal-article';
-            $orcidReview['subject-name'] = [
-                'title' => ['value' => $this->submission->getCurrentPublication()->getLocalizedTitle($submissionLocale) ?? '']
-            ];
+
+            $allTitles = $currentPublication->getData('title');
+            foreach ($allTitles as $locale => $title) {
+                if ($locale === $submissionLocale) {
+                    $orcidReview['subject-name']['title'] = ['value' => $title];
+                } else {
+                    $orcidReview['subject-name']['translated-title'] = ['value' => $title, 'language-code' => LocaleConversion::getIso1FromLocale($locale)];
+                }
+            }
 
             if (!empty($currentPublication->getDoi())) {
                 /** @var Doi $doiObject */
@@ -122,15 +128,6 @@ private function build(): array
             }
         }
 
-        $allTitles = $currentPublication->getData('title');
-        foreach ($allTitles as $locale => $title) {
-            if ($locale !== $submissionLocale) {
-                $iso1Locale = LocaleConversion::getIso1FromLocale($locale);
-                if ($iso1Locale) {
-                    $orcidReview['subject-name']['translated-title'] = ['value' => $title, 'language-code' => $iso1Locale];
-                }
-            }
-        }
 
         return $orcidReview;
     }