pkp/pkp-lib#3594 Add entity schema, Context API, and Vue.js forms #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NateWr
commented
Jul 17, 2018
NateWr
commented
- Add journal-specific context schema
- Update journal_settings db schema to remove setting_type
- Convert journal contact/masthead forms to Vue.js
|
|
NateWr
force-pushed
the
i3594_forms
branch
2 times, most recently
from
f854133
to
fe539e8
Compare
NateWr
force-pushed
the
i3594_forms
branch
2 times, most recently
from
cc14ae9
to
4dd3043
Compare
NateWr
force-pushed
the
i3594_forms
branch
6 times, most recently
from
e9a9c08
to
796d88e
Compare
NateWr
force-pushed
the
i3594_forms
branch
10 times, most recently
from
85d7454
to
1217330
Compare
asmecher
reviewed
Nov 9, 2018
asmecher
reviewed
Nov 9, 2018
asmecher
reviewed
Nov 9, 2018
asmecher
reviewed
Nov 9, 2018
|
Same business here as I posted on the pkp-lib PR :) |
NateWr
force-pushed
the
i3594_forms
branch
2 times, most recently
from
b4f9870
to
0b1dfcd
Compare
|
Just a few outstanding comments and that (Oh, except for OMP! 🛠️) |
NateWr
force-pushed
the
i3594_forms
branch
2 times, most recently
from
7d8fc34
to
272f5db
Compare
NateWr
force-pushed
the
i3594_forms
branch
16 times, most recently
from
fcf3b4a
to
dac45bd
Compare
asmecher
reviewed
Jan 8, 2019
| 'label' => __('manager.setup.journalAbbreviation'), | ||
| 'isMultilingual' => true, | ||
| 'value' => $context ? $context->getData('abbreviation') : null, | ||
| ]), ['after', 'acronym']); |
There was a problem hiding this comment.
Should e.g. 'after' be a defined constant?
- Add journal and site schema
- Load journal and site defaults from schema
- Add source file for generating API docs using cli tool
- Document /context, /site, /temporaryFiles, /context/{id}/themeOptions,
/_payments API endpoints
- Update journal_settings and site_settings db schema to remove setting_type
- Convert journal and site settings forms to Vue.js
- Deprecate Context::getSettings() in favor of Context::getData()
- Remove unused context settings: copyeditInstructions, refLinkInstructions,
metaCitations, authorSelfArchivePolicy
- Change sequence to seq in API to match underlying data structure
- Add json linting to tests
- Add private endpoint for handling payment settings forms
- Migrate handling of journal stylesheet to pkp-lib
- Migrate active block plugins from plugin_settings to journal_settings
- Move article permission reset to tools
- Improve authorization failure responses in API
- Replace metadata grid with form fields
- Remove unused Reading Tools locale strings
- Replace journal settings wizard
- Rename ListHandlers to ListPanels and move to /components directory
- Add licenseTerms in place of copyrightNotice on article landing
- Update help panel to avoid using .md extensions, to fix issues with
serves which try to serve the actual file instead of routing to our
handlers.
Namespacing and conventions:
- Use namespaces for form components
- Update autoload to use APP namespace instead of OJS so it can be used
across apps
- Use a shorter syntax for getting service classes
- Use interfaces and traits to enforce common patterns in service classes
- Replace APIRouter::getApiUrl with APIRouter::url
Fixes:
- Fix whitespace and quote issues in dbscripts
- Fix /submissions/{id}/participants endpoint
- Fix error displaying publishingMode value in form
- Fix typo in bounce address description
- Use description in HTML fields so value is not submitted
- Convert enableOai option to new forms
- Add error message for API requests that require a context
Tests:
- Fix invalid closing tags in locale file
- Add missing npm dependencies
- Fix add and setup journal tests
- Update help file validation to expect filenames without .md
- Bump vue-tabs-component version to fix id/hash bug
- Move /_payments API handler to pkp-lib - Replace journal with context in several locale keys - Remove unused locale strings - Move PaymentSettingsForm to pkp-lib - Fix docblock path in form components - Move several migration scripts to pkp-lib - Fix wrong docblock path in IssueQueryBuilder - Add @copydoc to ContextQueryBuilder - Fix typos in API documentation - Remove JournalGridHandler and move functions to ContextGridHandler - Move AccessForm to OJS and PaymentSettingsForm to pkp-lib - Move several context properties from pkp-lib to OJS and vice-versa - Restore accountName to paypal settings form - Move assignedToSection user query arg to OJS - Add placeholder AppearanceAdvancedForm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.