pkp/pkp-lib#9455 Add support for multiple occurrences on review reminders

[nibou230]

How to test

Configuring the reminders

1. Go to Settings, Workflow, Review, Set up
2. Ensure to set short delay in Default Response Deadline and Default Completion Deadline (or ensure to change dates when inviting a reviewer)
3. For reminder on the invitation:
   • In Response Reminder, enter 1 (the reminder will be trigger one day after deadline)
   • and in “Number of occurrences for the response reminder” enter at least 2
4. For reminder on the review report:
   • In Review Reminder enter 1 (the reminder will be trigger one day after deadline)
   • In “Number of occurrences for the review reminder” enter at least 2
5. Save changes

Testing the reminders

On invitation

1. Invite a new reviewer (with valid email adress) and ensure that the delay to respond to the invitation is the next day
2. 24h later the first reminder should be send to the review email adress
3. 48h later, the second one should be send.

On review reports

1. Invite a new reviewer (with valid adresse) and ensure that the delay to send the report is the next day)
2. Connect as reviewer, and accept the evaluation
3. 24h later the first reminder should be send to the review email adress
4. 48h later, the second one should be send.

[nibou230]

Hi! I'm asking myself.. Do I need to make a PR for each submodule as well?

I don't really understand why the Travis CI is failing, is it normal?

[asmecher]

@nibou230, your PR to the OJS app looks well-structured, thanks! There are a couple of Travis test failures, but those are random problems that sometimes happen during the test run -- generally speaking, if a few of the tests complete successfully, you should be OK. When you're ready to merge I'll make sure I restart any tests that seem to be failing randomly.

(We're in the process of moving from Travis to Github Actions; then we'll work to improve test stability after that.)

When you're happy with your PRs, list them in the issue and tag me, and I'll make sure the code changes get assigned for review. Thanks!

[jonasraoni]

@nibou230 Just to confirm... The tests should work fine without creating the PRs as long as the branch name matches. But yes, you'll have to create the PRs for the submodules too :)

[nibou230]

@jonasraoni Thanks, I was not sure about this! :)

[asmecher]

@nibou230, any of the locale keys here that are used in lib/pkp will need matching PRs for the omp and ops repositories.