Update CSVImportExportPlugin.php #1631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem was that givennames containing whitespaces with abrev. second names (e.g. John D.) and familynames that include dashes (e.g. Whatever-Name) were not imported. This update should improve this
|
Thanks, @klausru! @Godoy0722, this will probably collide with #1606 -- can you review and incorporate it as necessary? Thanks! |
Godoy0722
approved these changes
Jul 16, 2024
|
I'm also incorporating this into my updates. |
Godoy0722
added a commit
to Godoy0722/omp
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that givennames containing whitespaces with abrev. second names (e.g. John D.) and familynames that include dashes (e.g. Whatever-Name) were not imported. This update should improve this