Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ORCID connect button to user Identity tab #10315

Closed
ewhanson opened this issue Aug 14, 2024 · 3 comments
Closed

Move ORCID connect button to user Identity tab #10315

ewhanson opened this issue Aug 14, 2024 · 3 comments
Assignees
@taslangraham
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. Try Me This issue might be good for a new contributor. Can you help us?
Milestone
3.5.0 LTS

Comments

@ewhanson
Copy link
Collaborator

The ORCID connect button within the user profile is currently located in the Public tab (see photo). Through consultation with the PKP-ORCID working group, we've decided this should be relocated as part of the primary, "Identity" tab.

Screenshot of ORCID connect button in public tab

Notes

This will need to be completed on the main branch only.
This work will likely only touch the pkp-lib repository, but submodule commits should be made for OJS, OMP, and OPS.
@ewhanson ewhanson added Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. Try Me This issue might be good for a new contributor. Can you help us? labels Aug 14, 2024
@ewhanson ewhanson added this to the 3.5.0 LTS milestone Aug 14, 2024
@taslangraham taslangraham self-assigned this Aug 16, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 16, 2024
@taslangraham
pkp#10315 Move ORCID connect button to user Identity tab
4f688a6
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 17, 2024
@taslangraham
pkp#10315 Move ORCID connect button to user Identity tab
1d3ea63
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 17, 2024
@taslangraham
pkp#10315 Move ORCID connect button to user Identity tab
090a1f0
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Aug 17, 2024
@taslangraham
pkp#10315 Move ORCID connect button to user Identity tab
5803e4f
This was referenced Aug 19, 2024
Merged
Merged
taslangraham added a commit to taslangraham/omp that referenced this issue Aug 19, 2024
@taslangraham
pkp/pkp-lib#10315 submodule update
8a6106f
@taslangraham taslangraham mentioned this issue Aug 19, 2024
Merged
taslangraham added a commit to taslangraham/ojs that referenced this issue Aug 19, 2024
@taslangraham
pkp/pkp-lib#10315 submodule update
5c806fd
taslangraham added a commit to taslangraham/ops that referenced this issue Aug 19, 2024
@taslangraham
pkp/pkp-lib#10315 submodule update
792d0d9
@taslangraham taslangraham mentioned this issue Aug 19, 2024
Merged
@taslangraham
Copy link
Contributor

Read for review @ewhanson

PRs:

submodule updates:

ewhanson pushed a commit that referenced this issue Aug 19, 2024
@taslangraham @ewhanson
#10315 Move ORCID connect button to user Identity tab
e1cec28
ewhanson pushed a commit to pkp/ojs that referenced this issue Aug 19, 2024
@taslangraham @ewhanson
pkp/pkp-lib#10315 submodule update
63a37fb
ewhanson pushed a commit to pkp/omp that referenced this issue Aug 19, 2024
@taslangraham @ewhanson
pkp/pkp-lib#10315 submodule update
c074113
ewhanson pushed a commit to pkp/ops that referenced this issue Aug 19, 2024
@taslangraham @ewhanson
pkp/pkp-lib#10315 submodule update
2d4d2e6
@ewhanson
Copy link
Collaborator Author

Thanks, @taslangraham. All looks good so I've merged it!

@github-project-automation github-project-automation bot moved this from Backlog to Done in Metadata and Distribution Aug 19, 2024
@taslangraham
Copy link
Contributor

Thanks for the review @ewhanson

Hafsa-Naeem pushed a commit to Hafsa-Naeem/ojs that referenced this issue Aug 26, 2024
@taslangraham @Hafsa-Naeem
pkp/pkp-lib#10315 submodule update
042c8ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taslangraham taslangraham

Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. Try Me This issue might be good for a new contributor. Can you help us?
Projects
Metadata and Distribution
Status: Done
Milestone
3.5.0 LTS
Development

No branches or pull requests
2 participants
@ewhanson @taslangraham