-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance problem in "recommend by author" plugin #5887
Comments
For a multi-tenant install or an install with unrelated journals, it would be preferable to keep this plugin to be constrained by journal or to add a setting to retain this functionality. |
Was this fixed for 3.3? |
No, I don't think there's been any dev activity on this one yet. |
@mfelczak, this feature currently searches OJS's author records by given and last name, looking for exact matches. This performs badly but also doesn't align with our plans for author disambiguation using ORCIDs. Do the clients who are asking for this feature tend to use ORCIDs? |
Hi @asmecher, I don't have a firm sense of ORCID adoption across our hosted journals as it's not something that we currently track. We could provide some stats though if that might be helpful, e.g. checking whether the ORCID plugin is enabled. |
Rather than stats for existing users, I'd be curious whether editors think adopting it in place of "recommend by author" would meet that feature's need. At best, an OJS-based author list can only show the results in that single installation; using ORCiD, it'll be a global list of everything that author has written. I suspect end users interested in following an author would much prefer the latter. Editors might want the former as a "brag page" but I'm not sure it'll help researchers. |
I can confirm this plugin is a bit resource intensive. As I've a good place to test some improvements, I've assigned it to me. |
Has there much headway in improving the performance of this plugin? We run a large multi-journal site and was having some major performance issues which we've narrowed down to this. For now we've disabled the plugin but if you have any suggestions as to how we can make some temporary workarounds while you work on improvements that'll be greatly appreciated. |
The "Recommend By Author" plugin queries for an author across all journals in the installation, in all supported locales. With large numbers of authors and more than a few locales, this can get quite slow.
The issue was reported (by @ajnyga) in OJS 3.1.2; in OJS 3.2.0, the query appears to have been rewritten to be journal-constrained, which is probably not intentional.
The text was updated successfully, but these errors were encountered: