Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issues at the plugin "Recommend By Similarity" #8710

Closed
jonasraoni opened this issue Mar 1, 2023 · 8 comments · Fixed by #8912, pkp/ojs#3804, pkp/ojs#3874, #9258 or pkp/ojs#4026
Closed

Performance issues at the plugin "Recommend By Similarity" #8710

jonasraoni opened this issue Mar 1, 2023 · 8 comments · Fixed by #8912, pkp/ojs#3804, pkp/ojs#3874, #9258 or pkp/ojs#4026
Assignees
@jonasraoni

Comments

@jonasraoni
Copy link
Contributor

jonasraoni commented Mar 1, 2023 •
edited
Loading

Describe the bug
This plugin is causing an excessive delay on the article response, even when the server isn't under heavy load.

As an example, a single article takes < 2s to be loaded, but once the plugin is enabled, it goes up to 10s (when the server a bit loaded, the number went up to 60s)

What application are you using?
OJS/stable-3_3_0
@jonasraoni jonasraoni self-assigned this Mar 1, 2023
@jonasraoni
Copy link
Contributor Author

As part of this assignment, I might end up solving related issues at the plugin (#7866, #8633)

@jonasraoni jonasraoni mentioned this issue Mar 2, 2023
Closed
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Mar 2, 2023
@jonasraoni
pkp/pkp-lib#8710 Improved the performance of the RecommendBySimilarit…
8b360fa 
…yPlugin by skipping the ArticleSearch internals
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Mar 2, 2023
@jonasraoni
pkp/pkp-lib#8710 Added todo reminder
017b699
@jonasraoni
Copy link
Contributor Author

jonasraoni commented Mar 3, 2023 •
edited
Loading

@asmecher here's an initial PR for this one, if you agree, then I'll create extra PRs wherever is needed, I left some comments in case it helps:

jonasraoni added a commit to jonasraoni/ojs that referenced this issue Apr 7, 2023
@jonasraoni
pkp/pkp-lib#8710 Improved the performance of the RecommendBySimilarit…
61c804e 
…yPlugin by skipping the ArticleSearch internals
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Apr 7, 2023
@jonasraoni
pkp/pkp-lib#8710 Added todo reminder
67e9ecd
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Apr 7, 2023
@jonasraoni
pkp/pkp-lib#8710 Formatted and added comments
cde2101
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Added filter to exclude submission IDs
95d2c9d
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Updated assignedTo exception to ignore only the author name
1f27175
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Added $allowShortWords to the SubmissionSearchIndex::filterK…
e2a7822 
…eywords()
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Updated searchPhrase filter to look for matches at the index…
be9d65a 
…ed content, and to use a "OR" based search instead to bring more results
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Added sort by search ranking
1d2ccad
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Formatting
65d09d6
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Added filter to exclude submission IDs
db1e769
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Updated assignedTo exception to ignore only the author name
5161ccf
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Added $allowShortWords to the SubmissionSearchIndex::filterK…
60f06c5 
…eywords()
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Updated searchPhrase filter to look for matches at the index…
57c08f1 
…ed content, and to use a "OR" based search instead to bring more results
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Added sort by search ranking
2bda9e0
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 12, 2023
@jonasraoni
pkp#8710 Formatting
c5e5bb8
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Apr 12, 2023
@jonasraoni
pkp/pkp-lib#8710 Updated Recommend by Similarity plugin to use the su…
8d743ee 
…bmission collector
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Apr 12, 2023
@jonasraoni
pkp/pkp-lib#8710 Submodule update ##jonasraoni/feature/main/8710-addr…
ef1605b 
…ess-recommend-by-similarity-performance##
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 13, 2023
@jonasraoni
pkp#8710 Added $allowNumericWords to the SubmissionSearchIndex::filte…
4d3c24f 
…rKeywords()
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 13, 2023
@jonasraoni
pkp#8710 Fixed sorting and numeric search (submission ID)
a7c98f9
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Apr 13, 2023
@jonasraoni
pkp/pkp-lib#8710 Fixed offset issues
7b82966
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Apr 13, 2023
@jonasraoni
pkp/pkp-lib#8710 Submodule update ##jonasraoni/feature/main/8710-addr…
a495d4b 
…ess-recommend-by-similarity-performance##
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 13, 2023
@jonasraoni
pkp#8710 Added filter to exclude submission IDs
659000e
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 13, 2023
@jonasraoni
pkp#8710 Updated assignedTo exception to ignore only the author name
8a91ef1
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Apr 13, 2023
@jonasraoni
pkp#8710 Added $allowShortWords to the SubmissionSearchIndex::filterK…
c64d260 
…eywords()
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Added sort by search ranking
5a6b884
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Formatting
9b66011
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Added $allowNumericWords to the SubmissionSearchIndex::filte…
eb9b5ba 
…rKeywords()
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Fixed sorting and numeric search (submission ID)
ee59ab4
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Updated comments
33d7922
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Aug 25, 2023
@jonasraoni
pkp/pkp-lib#8710 Formatting
43e5736
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Aug 25, 2023
@jonasraoni
pkp/pkp-lib#8710 Submodule update ##jonasraoni/feature/stable-3_4_0/8…
99da73a 
…710-address-recommend-by-similarity-performance##
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Added optional maxSearchKeywords parameter
f477ec8
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Aug 25, 2023
@jonasraoni
pkp/pkp-lib#8710 Updated Recommend by Similarity plugin to use the su…
6fe3a8e 
…bmission collector
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Aug 25, 2023
@jonasraoni
pkp/pkp-lib#8710 Fixed offset issues
fa12a75
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Aug 25, 2023
@jonasraoni
pkp/pkp-lib#8710 Added keyword limit to the search
236f6d0
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Aug 25, 2023
@jonasraoni
pkp/pkp-lib#8710 Submodule update ##jonasraoni/feature/stable-3_4_0/8…
f615e6e 
…710-address-recommend-by-similarity-performance##
This was linked to pull requests Aug 25, 2023
Feature/stable 3 4 0/8710 address recommend by similarity performance #9258
Merged
Feature/stable 3 4 0/8710 address recommend by similarity performance pkp/ojs#4026
Merged
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Added filter to exclude submission IDs
768ddbb
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Updated assignedTo exception to ignore only the author name
6ae9f94
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Added $allowShortWords to the SubmissionSearchIndex::filterK…
14d11e2 
…eywords()
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Updated searchPhrase filter to look for matches at the index…
1d49d30 
…ed content, and to use a "OR" based search instead to bring more results
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Added sort by search ranking
dbb7dd5
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Formatting
8e2d78d
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Added $allowNumericWords to the SubmissionSearchIndex::filte…
819508c 
…rKeywords()
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Fixed sorting and numeric search (submission ID)
3ff69bf
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Updated comments
73cb3b9
jonasraoni added a commit to jonasraoni/pkp-lib that referenced this issue Aug 25, 2023
@jonasraoni
pkp#8710 Added optional maxSearchKeywords parameter
47911b4
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Aug 25, 2023
@jonasraoni
pkp/pkp-lib#8710 Updated Recommend by Similarity plugin to use the su…
af2dcf2 
…bmission collector
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Aug 25, 2023
@jonasraoni
pkp/pkp-lib#8710 Fixed offset issues
b4311c4
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Aug 25, 2023
@jonasraoni
pkp/pkp-lib#8710 Added keyword limit to the search
98af26d
jonasraoni added a commit to jonasraoni/ojs that referenced this issue Aug 25, 2023
@jonasraoni
pkp/pkp-lib#8710 Submodule update ##jonasraoni/feature/main/8710-addr…
d805189 
…ess-recommend-by-similarity-performance##
@jonasraoni jonasraoni mentioned this issue Oct 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasraoni jonasraoni

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@asmecher @jonasraoni @Vitaliy-1