Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disentangle beacon and upgrade warning disables #6457

Closed
asmecher opened this issue Dec 7, 2020 · 1 comment
Closed

Disentangle beacon and upgrade warning disables #6457

asmecher opened this issue Dec 7, 2020 · 1 comment
Assignees
@asmecher
Milestone
OJS/OMP/OPS 3.3.0

Comments

@asmecher
Copy link
Member

asmecher commented Dec 7, 2020

Both the beacon (enable_beacon) and upgrade warning (show_upgrade_warning) options can be disabled in config.inc.php. However, it appears that disabling show_upgrade_warning also kills the beacon. Disentangle them so that the upgrade warning can be disabled without force-disabling the beacon.
@asmecher asmecher added this to the OJS/OMP/OPS 3.3 milestone Dec 7, 2020
asmecher added a commit that referenced this issue Dec 9, 2020
@asmecher
#6457 Disentangle beacon enable/disable from upgrade warning
b32509e
asmecher added a commit that referenced this issue Dec 9, 2020
@asmecher
#6457 Disentangle beacon enable/disable from upgrade warning (stable-…
632f63e 
…3_2_1)
asmecher added a commit that referenced this issue Dec 9, 2020
@asmecher
#6457 Disentangle beacon enable/disable from upgrade warning (stable-…
f9826bf 
…3_2_1)
@asmecher
Copy link
Member Author

asmecher commented Dec 9, 2020

Committed and back-ported to OJS/OMP/OPS 3.2.x stable branches.

@asmecher asmecher closed this as completed Dec 9, 2020
@asmecher asmecher self-assigned this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asmecher asmecher

Labels
None yet
Projects
None yet
Milestone
OJS/OMP/OPS 3.3.0
Development

No branches or pull requests
1 participant
@asmecher