Review Report contains duplicate rows

[kaitlinnewson]

Describe the bug
When exporting the Review Report in OJS 3.3.0-6/8, many of the rows are duplicated.

To Reproduce
Steps to reproduce the behavior:

1. Download the Review Report in Statistics > Report.
2. Open the downloaded CSV file.
3. Review the file to note duplicated rows. If in Excel, the "Remove Duplicates" feature can also be used to indicate how many duplicates there are.

What application are you using?
OJS version 3.3.0-6 & 3.3.0-8

[asmecher]

Appears to be related: https://forum.pkp.sfu.ca/t/review-reports-showing-duplicates/69916

[asmecher]

@kaitlinnewson, I'm afraid I can't replicate this locally; can you contact me privately with details about where you're seeing it?

[asmecher]

I've confirmed that this is #7167; there is a (long) SQL query that can resolve the issue here: #7414 (comment)

Please make sure to take a good database backup before executing it!

[DigitalCardigan]

This is listed as closed, but we are having this issue of duplicated rows in reports in OJS 3.3.0.12. Is there a way to correct this? I see there is a suggested SQL fix in a related thread, however, that's an old thread specific to 3.3.0 and we are not having the slow user search issue described in that thread.
My editors want to be able to use this report feature but it is just rows and rows of repeated data.

[jonasraoni]

@DigitalCardigan We don't run database updates on minor OJS upgrades, so if your installation is older than the fix, it's expected to have the problem.

And for the same reason, that we don't upgrade the database, it should be ok to run the query while you're under 3.3.0-X :)

About the slow user search, it should happen once you have a considerable number of users in the system.

[DigitalCardigan]

@jonasraoni Thank you for the reply. I think my confusion is that the fix linked to above in this thread has a note under it "Updated the code to deal with duplicated user_settings"
committed in Nov 2021 referencing 3.3.0.

I am trying to understand if the code listed on that page shows what was changed in the base code for subsequent upgrades OR if that is just showing the code we are meant to use on our own?

We are on 3.3.0.12 - my interpretation was that since this issue is listed as closed, it would have been resolved during our upgrades since Nov. 2021? We last upgraded Sept 2022.

I am new to GitHub so I apologize if I'm not interpreting this correctly.

[jonasraoni]

@DigitalCardigan The code you've linked is the one supposed to just improve the speed :)

Back to the topic, the issue happens at upgrade time, when you're moving from an older version (e.g. 3.2.x) to 3.3.0, the fix is here: https://github.com/pkp/pkp-lib/pull/7472/files, but it will just address systems which didn't upgrade yet.

---

If you've upgraded, then you need to run this query: #7414 (comment)

Also, this script will be executed automatically once you upgrade to OJS 3.4.0 (we're on the testing phase, so it's going to be released soon).

[DigitalCardigan]

@jonasraoni Thank you for the help!