Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#7167 Avoid duplicated user_settings #7472

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions classes/migration/upgrade/PKPv3_3_0UpgradeMigration.inc.php
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,6 @@ public function up() {
});
}

// Use nulls instead of 0 for assoc_type/id in user_settings
Capsule::table('user_settings')->where('assoc_type', 0)->update(['assoc_type' => null]);
Capsule::table('user_settings')->where('assoc_id', 0)->update(['assoc_id' => null]);

// pkp/pkp-lib#6093 Don't allow nulls (previously an upgrade workaround)
Capsule::schema()->table('announcement_types', function (Blueprint $table) {
$table->bigInteger('assoc_type')->nullable(false)->change();
Expand Down