Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP8.1 testing to Travis environment #7690

Closed
asmecher opened this issue Feb 10, 2022 · 2 comments
Closed

Add PHP8.1 testing to Travis environment #7690

asmecher opened this issue Feb 10, 2022 · 2 comments
Assignees
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone

Comments

@asmecher
Copy link
Member

asmecher commented Feb 10, 2022

OJS/OMP/OPS 3.3.0 and main (pre-3.4) should be tested against PHP8.1.

PRs:

@asmecher asmecher self-assigned this Feb 10, 2022
asmecher added a commit to asmecher/ojs that referenced this issue Feb 10, 2022
asmecher added a commit to pkp/ojs that referenced this issue Feb 10, 2022
asmecher added a commit to pkp/ojs that referenced this issue Feb 10, 2022
asmecher added a commit to pkp/ojs that referenced this issue Feb 10, 2022
asmecher added a commit to pkp/ojs that referenced this issue Feb 10, 2022
asmecher added a commit to pkp/ojs that referenced this issue Feb 10, 2022
@asmecher
Copy link
Member Author

asmecher commented Feb 10, 2022

It looks like PHP8.1 support is not yet great on Travis.

There are a lot of discussions about backwards compatibility being broken in the PHP internals list:
https://externals.io/message/115683

This is also relevant: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg

For some reason I haven't been able to track down yet, PHP really wants to dump these to stdout, breaking AJAX interactions and redirects. This seems to be due to something in OJS or a dependency; a straight-up call to an affected function in vanilla PHP doesn't seem to mind. (Looking at you, Smarty?)


Edit: It looks like 8.1.0 is available specifically for most distros, but there is no 8.1 alias as there is for previous major branches.

Smarty is indeed pickier, and many of the adjustments have gone there. In particular, passing a null through |escape now causes an error due to https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg.

asmecher added a commit to pkp/ojs that referenced this issue Feb 10, 2022
@NateWr NateWr added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Feb 14, 2022
asmecher added a commit that referenced this issue Feb 15, 2022
asmecher added a commit that referenced this issue Feb 15, 2022
asmecher added a commit to pkp/ojs that referenced this issue Feb 15, 2022
asmecher added a commit that referenced this issue Feb 16, 2022
asmecher added a commit that referenced this issue Feb 16, 2022
asmecher added a commit that referenced this issue Feb 16, 2022
asmecher added a commit to pkp/ops that referenced this issue Feb 16, 2022
asmecher added a commit to pkp/ojs that referenced this issue Feb 17, 2022
asmecher added a commit to pkp/ops that referenced this issue Feb 17, 2022
asmecher added a commit to pkp/omp that referenced this issue Feb 17, 2022
asmecher added a commit to pkp/omp that referenced this issue Feb 17, 2022
@asmecher asmecher added this to the 3.4 milestone Feb 18, 2022
@asmecher
Copy link
Member Author

Until we're early in a 3.3.0-x release cycle, and until 3.1.0 gets a little stabler, I've committed the changes to main and not stable-3_3_0.

asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 17, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 17, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 17, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 17, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 17, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 17, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 17, 2022
asmecher added a commit to asmecher/ojs that referenced this issue Oct 17, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 18, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 18, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 18, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 18, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 18, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 18, 2022
asmecher added a commit to asmecher/pkp-lib that referenced this issue Oct 18, 2022
asmecher added a commit to asmecher/ojs that referenced this issue Oct 18, 2022
asmecher added a commit that referenced this issue Oct 25, 2022
asmecher added a commit that referenced this issue Oct 25, 2022
asmecher added a commit that referenced this issue Oct 25, 2022
asmecher added a commit that referenced this issue Oct 25, 2022
asmecher added a commit that referenced this issue Oct 25, 2022
asmecher added a commit to asmecher/ojs that referenced this issue Oct 25, 2022
asmecher added a commit to pkp/ojs that referenced this issue Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
None yet
Development

No branches or pull requests

2 participants