-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UI/UX of file attachments in new Composer UI #7799
Comments
I decided to leave the following two features for later. They are nice to have but not urgent:
Otherwise, the following PRs apply styles to the file attacher, introduce a new PRs: |
@ewhanson would you be able to do a code review on this? I'm particularly interested in having you check the keyboard navigation functionality. This fixes some focus bugs related to accessibility, and those tend to be where there are differences between browsers, and since you're on Mac we're likely to get some different behaviour. To test in the UI Library:
To test in OJS:
|
Hey @NateWr, I'll have a look. Thanks! |
Hey @NateWr, I've reviewed the code and done some keyboard navigation testing. The code all looked good, but I ran into a few issues with Firefox on Mac and (perhaps not surprisingly) a number of issues with Safari on Mac. Anything that came up in Firefox was also applicable in Safari. This also wasn't explicitly in this PR, but the readme file for the FirefoxComposer (UI Library)
In OJS
SafariActionPanel (UI Library)
Composer (UI Library)
In OJS
|
#7799 Fix fileStages param in submission file API and use ActionPanel on admin page
pkp/pkp-lib#7799 Add ActionPanel and improve UX of FileAttacher components
pkp/pkp-lib#7799 Use ActionPanel in admin UI
pkp/pkp-lib#7799 Use ActionPanel in admin UI
pkp/pkp-lib#7799 Use ActionPanel on admin page
After a short call with Erik, the issues were all related to a system default in Mac that alters keyboard navigation. 😅 I've merged all the PRs to |
Describe the problem you would like to solve
The file attachments UI components work fine in the new
Composer
component. However, they have not been styled appropriately. In some cases they are missing styles completely.Describe the solution you'd like
The following needs to be done:
Who is asking for this feature?
Finishing work on #5717.
The text was updated successfully, but these errors were encountered: