Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade eslint rules for Vue, from 'essential' to 'recommended' #9538

Closed
jardakotesovec opened this issue Nov 27, 2023 · 1 comment
Closed

Upgrade eslint rules for Vue, from 'essential' to 'recommended' #9538

jardakotesovec opened this issue Nov 27, 2023 · 1 comment
Assignees
@jardakotesovec
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone
3.5.0 LTS

Comments

@jardakotesovec
Copy link
Contributor

Static analysis in form of Eslint is very valuable and helps with some code consistency as well as catching some mistakes.

While updating to vue3 I intentionally went for plugin:vue/vue3-essential ruleset to avoid significant number of automatic code changes in our Vue.js codebase.

Intention of this issue to upgrade to extended set of rules plugin:vue/vue3-recommended which helps us to follow vue3 recommendation for coding.
@jardakotesovec jardakotesovec added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Nov 27, 2023
@jardakotesovec jardakotesovec added this to the 3.5.0 LTS milestone Nov 27, 2023
@jardakotesovec jardakotesovec self-assigned this Nov 27, 2023
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Nov 27, 2023
@jardakotesovec
pkp/pkp-lib#9538 Apply recommended lint rules for vue3
7d5b959
jardakotesovec added a commit to pkp/ui-library that referenced this issue Nov 27, 2023
@jardakotesovec
pkp/pkp-lib#9538 Apply recommended lint rules for vue3
c2aa1fe
@jardakotesovec
Copy link
Contributor Author

jardakotesovec commented Nov 27, 2023 •
edited
Loading

PR for ui-library pkp/ui-library#301

Merged as these are automatic changes, which should be safe, therefore no review needed.

As result there is bunch of warnings. Overtime lets aim to get that to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jardakotesovec jardakotesovec

Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
1 participant
@jardakotesovec