Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create FieldSlider component #9857

Closed
jardakotesovec opened this issue Apr 2, 2024 · 3 comments
Closed

Create FieldSlider component #9857

jardakotesovec opened this issue Apr 2, 2024 · 3 comments
Assignees
@jardakotesovec
Labels
UI/UX Issues affecting the user interface/user experience
Milestone
3.5.0 LTS

Comments

@jardakotesovec
Copy link
Contributor

Describe the feature
For Submission listing and Review reminders we need form field slider with following features:

  • field label
  • custom labels for min/max values
  • custom value label for min/max for current value
  • min/max values

image
@jardakotesovec jardakotesovec self-assigned this Apr 2, 2024
@jardakotesovec jardakotesovec added the UI/UX Issues affecting the user interface/user experience label Apr 2, 2024
@jardakotesovec jardakotesovec added this to the 3.5.0 LTS milestone Apr 2, 2024
jardakotesovec added a commit to jardakotesovec/pkp-lib that referenced this issue Apr 2, 2024
@jardakotesovec
pkp#9857 FieldSlider
d786c02
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Apr 2, 2024
@jardakotesovec
pkp/pkp-lib#9857 FieldSlider initial implementation
a42ca08
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Apr 2, 2024
@jardakotesovec
pkp/pkp-lib#9857 Update color classes
52651f6
@jardakotesovec
Copy link
Contributor Author

Added new dependency primevue.

Landscape of headless libraries for Vue.js is evolving rapidly and hard to say whether one day there will be one which can handle all our needs. But for now bringing primevue, which now supports headless mode.

  • It has strong focus on accessibility.
  • It has small footprint.
  • Its easy to style with tailwindcss.
  • And it has very large collection of components - we might use some of them to replace some of our scattered dependencies (uploader, color field)..
  • We might use date picker from primevue

ojs: pkp/ojs#4233
pkp-lib: https://github.com/pkp/pkp-lib/pull/9858/files
ui-library: pkp/ui-library#343

@touhidurabir Finally have slider for you :-), could you please help with review? Thanks!

@jardakotesovec
Copy link
Contributor Author

@eirikhanssen Can I ask you for code review on this one as well? Thanks!

jardakotesovec added a commit to jardakotesovec/pkp-lib that referenced this issue Apr 8, 2024
@jardakotesovec
pkp#9857 FieldSlider
9665558
jardakotesovec added a commit to jardakotesovec/ui-library that referenced this issue Apr 9, 2024
@jardakotesovec
pkp/pkp-lib#9857 Add step prop
93e3324
jardakotesovec added a commit to jardakotesovec/pkp-lib that referenced this issue Apr 9, 2024
@jardakotesovec
pkp#9857 Add step prop and allow float for min&max&step
94229ac
jardakotesovec added a commit to pkp/ui-library that referenced this issue Apr 10, 2024
@jardakotesovec
I9857 slider (#343)
8078854 
* pkp/pkp-lib#9857 FieldSlider initial implementation

* pkp/pkp-lib#9857 Update color classes

* pkp/pkp-lib#9857 Add step prop
jardakotesovec added a commit that referenced this issue Apr 10, 2024
@jardakotesovec
#9857 FieldSlider (#9858)
394072d 
* #9857 FieldSlider

* #9857 Add step prop and allow float for min&max&step
jardakotesovec added a commit to pkp/omp that referenced this issue Apr 10, 2024
@jardakotesovec
pkp/pkp-lib#9857 Add primevue dependency
70be0ad
jardakotesovec added a commit to pkp/ops that referenced this issue Apr 10, 2024
@jardakotesovec
pkp/pkp-lib#9857 Add primevue dependency
24d6a51
@jardakotesovec
Copy link
Contributor Author

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jardakotesovec jardakotesovec

Labels
UI/UX Issues affecting the user interface/user experience
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
1 participant
@jardakotesovec